[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#321772: Module ns558 needs to be loaded twice to work properly



Hi!

I am sorry to tell you that the patches did not work with the current kernel-source-2.6.8 (2.6.8-16)!

I tried with both gcc-3.3 and gcc-3.4 and allways got the following error message from make-kpkg:

 CC [M]  drivers/input/gameport/ns558.o
drivers/input/gameport/ns558.c: In function `ns558_isa_probe':
drivers/input/gameport/ns558.c:145: warning: implicit declaration of function `kcalloc' drivers/input/gameport/ns558.c:145: warning: assignment makes pointer from integer without a cast drivers/input/gameport/ns558.c:146: warning: implicit declaration of function `gameport_allocate_port' drivers/input/gameport/ns558.c:146: warning: assignment makes pointer from integer without a cast drivers/input/gameport/ns558.c:151: warning: implicit declaration of function `gameport_free_port' drivers/input/gameport/ns558.c:161: warning: implicit declaration of function `gameport_set_name' drivers/input/gameport/ns558.c:162: warning: implicit declaration of function `gameport_set_phys'
drivers/input/gameport/ns558.c: In function `ns558_pnp_probe':
drivers/input/gameport/ns558.c:218: warning: assignment makes pointer from integer without a cast drivers/input/gameport/ns558.c:219: warning: assignment makes pointer from integer without a cast drivers/input/gameport/ns558.c:234: error: request for member `parent' in something not a structure or union
make[3]: *** [drivers/input/gameport/ns558.o] Error 1
make[2]: *** [drivers/input/gameport] Error 2
make[1]: *** [drivers] Error 2
make[1]: Leaving directory `/usr/src/kernel-source-2.6.8'
make: *** [stamp-build] Error 2

I do not know if it is my fault, but I did not get it compiled at all after applying the patches. By the way, I had to apply the patches in the order ns558-pnp.diff first, ns558-load.diff second,
else `patch` would tell me

patching file ns558.c
Hunk #1 FAILED at 258.
1 out of 1 hunk FAILED -- saving rejects to file ns558.c.rej

I would appreciate if you could build a kernel-image for me, so I could test it on my PC at home.
I was not able to make one myself... *shame* :(

Thank you in advance! ;)

Nice greetings,
Fabian



I strongly suspect that this patch fixes this problem
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f6397cecadc52779902bdd8f8cd3ea5af3a19ad1

That patch also depends on this patch, which seems to fix some more insmod/rmmod nastiness
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/old-2.6-bkcvs.git;a=blobdiff;h=7c5c6318eeb9ffad3b1798fca4e1a13b8239689e;hp=f31ce0bad57942b7a66f01540b3816ed2ced8762;hb=913a66fbd55ce7ed0191d267306d6fa3181d98b1;f=drivers/input/gameport/ns558.c

I've attached thes second patches as ns558-load.diff and
the first patch as  ns558-pnp.diff. (They need to be
applied in that order). If I make images are you in a position
to test them. Alternatively, you could try linux-image-2.6.12-1-k7 image from unstable.




Reply to: