[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] hfs, hfsplus: don't leak s_fs_info and fix an oops



On Fri, Oct 07, 2005 at 09:10:05AM +0200, Colin Leroy wrote:
> On 07 Oct 2005 at 13h10, Horms wrote:
> 
> Hi, 
> 
> > I took a look at making a backport, and it seems that
> > some of the problems are there, but without a deeper inspection
> > of the code its difficult to tell if the problems manifest or not.
> 
> That was easy to get the oops:
> 
> $ dd if=/dev/zero of=im_not_hfsplus count=10 #for example
> $ mkdir test_dir
> $ sudo mount -o loop -t hfsplus ./im_not_hfsplus ./testdir
> $ dmesg

After an extended delay I have been able to confirm that the above
commands do not cause 2.4 (Debian's 2.4.27) to do anything unusal.

Mount just reports:
  mount: wrong fs type, bad option, bad superblock on /dev/loop0,
       or too many mounted file systems

And there is nothing exciting in dmsg:
  loop: loaded (max 8 devices)
  HFS+-fs: unable to find HFS+ superblock
  HFS+-fs: unable to find HFS+ superblock
  HFS+-fs: unable to find HFS+ superblock

Thus it seems that 2.4 does not suffer from this bug.

-- 
Horms



Reply to: