[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#337168: marked as done (yaird fails to parse "LABEL=/" correctly)



Your message dated Thu, 10 Nov 2005 14:48:11 -0800
with message-id <E1EaLDH-0008I0-OS@spohr.debian.org>
and subject line Bug#337415: fixed in yaird 0.0.11-12
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 3 Nov 2005 00:02:20 +0000
>From michael@stroucken.org Wed Nov 02 16:02:20 2005
Return-path: <michael@stroucken.org>
Received: from ascient.net [66.199.228.123] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1EXSYe-0005ee-00; Wed, 02 Nov 2005 16:02:20 -0800
Received: (qmail 5289 invoked by uid 112); 3 Nov 2005 00:02:17 -0000
Received: from pinguin.wv.cc.cmu.edu (HELO ?128.237.236.6?) (mxs@ascient.com@128.237.236.6)
  by ascient.net with (DHE-RSA-AES256-SHA encrypted) SMTP; 3 Nov 2005 00:02:17 -0000
Message-ID: <4369536C.6010108@stroucken.org>
Date: Wed, 02 Nov 2005 19:01:48 -0500
From: Michael Stroucken <michael@stroucken.org>
User-Agent: Debian Thunderbird 1.0.7 (X11/20051017)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: submit@bugs.debian.org
X-Enigmail-Version: 0.93.0.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.5 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	NOSUBJECT autolearn=no version=2.60-bugs.debian.org_2005_01_02

Subject: fails to parse "LABEL=/" correctly
Package: yaird
Version: 0.0.11-10
Severity: normal
Tags: patch

Hi,

        yaird gives an error when it parses my fstab, saying that label ()
wasn't found. My fstab contains the lines
LABEL=/         /               ext3    defaults,errors=remount-ro 0       1
LABEL=/boot     /boot           ext3    defaults        0       2
but yaird thinks the root partition label has an extra trailing slash,
and removes it, leaving an empty label.

A quick and dirty patch is attached.

Greetings,
Michael.

--- FsTab.pm.old        2005-10-30 07:04:57.000000000 -0500
+++ FsTab.pm    2005-11-02 18:43:22.000000000 -0500
@@ -62,9 +62,14 @@
                #
                # Canon makes sure that mountpoint /usr is same as /usr/.
                # For UUID= devices, it should be harmless.
+               # But it isn't for LABEL= devices (ms)
                #
+               my $dev = unmangle($fields[0]);
+               if ($dev !~ m/^(LABEL|UUID)=/) {
+                       $dev = Base::canon ($dev);
+               }
                my $descr = FsEntry->new(
-                       dev => Base::canon (unmangle($fields[0])),
+                       dev => $dev,
                        mnt => Base::canon (unmangle($fields[1])),
                        type => unmangle($fields[2]),
                        opts => $opts,


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-1-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages yaird depends on:
ii  cpio                         2.6-9       GNU cpio -- a program to
manage ar
ii  dash                         0.5.2-8     The Debian Almquist Shell
ii  libc6                        2.3.5-7     GNU C Library: Shared
libraries an
ii  libhtml-template-perl        2.6-2       HTML::Template : A module
for usin
ii  libparse-recdescent-perl     1.94.free-1 Generates recursive-descent
parser
ii  perl                         5.8.7-7     Larry Wall's Practical
Extraction

yaird recommends no packages.

-- no debconf information


---------------------------------------
Received: (at 337415-close) by bugs.debian.org; 10 Nov 2005 22:52:37 +0000
>From katie@ftp-master.debian.org Thu Nov 10 14:52:37 2005
Return-path: <katie@ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
	id 1EaLDH-0008I0-OS; Thu, 10 Nov 2005 14:48:11 -0800
From: Jonas Smedegaard <dr@jones.dk>
To: 337415-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#337415: fixed in yaird 0.0.11-12
Message-Id: <E1EaLDH-0008I0-OS@spohr.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Thu, 10 Nov 2005 14:48:11 -0800
Delivered-To: 337415-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 4

Source: yaird
Source-Version: 0.0.11-12

We believe that the bug you reported is fixed in the latest version of
yaird, which is due to be installed in the Debian FTP archive:

yaird_0.0.11-12.diff.gz
  to pool/main/y/yaird/yaird_0.0.11-12.diff.gz
yaird_0.0.11-12.dsc
  to pool/main/y/yaird/yaird_0.0.11-12.dsc
yaird_0.0.11-12_powerpc.deb
  to pool/main/y/yaird/yaird_0.0.11-12_powerpc.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 337415@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonas Smedegaard <dr@jones.dk> (supplier of updated yaird package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 10 Nov 2005 15:24:37 +0100
Source: yaird
Binary: yaird
Architecture: source powerpc
Version: 0.0.11-12
Distribution: unstable
Urgency: low
Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
Changed-By: Jonas Smedegaard <dr@jones.dk>
Description: 
 yaird      - Yet Another mkInitRD
Closes: 337168 337415 337479 337855 338228
Changes: 
 yaird (0.0.11-12) unstable; urgency=low
 .
   * Explicitly use /usr/bin/perl as script hashbang. Closes: bug#337479
     (thanks to Laurent Bonnaud <bonnaud@lis.inpg.fr>, Mattia Dongili
     <malattia@linux.it>, Christoph Berg <myon@debian.org> and others).
   * Use DEB_PERL_INCLUDE (not DEB_DH_PERL_ARGS) as path to perl modules.
   * Add patch 0096 to recognize DAC960_devices (needs more testing).
   * Add patch 0097 unifying the various ways to run commands, and fixing
     old behaviour of ldd run to tolerate static binaries. Closes:
     bug#337855 (thanks to Walter Hofmann
     <yaird-bug-051106231035-aa10@secretlab.mine.nu>).
   * Add patch 0098 adding support for new input system sysfs format to
     be included with 2.6.15. Closes: bug#338228 (thanks to Rutger
     Nijlunsing <debian-bugs@tux.tmfweb.nl>).
   * Add patch 1098 to avoid unmangling fstab LABELs. Closes: bug#337415,
     #337168 (thanks to Davide G. M. Salvetti" <salve@debian.org> and
     Michael Stroucken <michael@stroucken.org>).
   * Add patch 0099 to recognize Apple "mesh" SCSI driver (and revert
     wrong extension of patch 1075 in previous release). Hopefully fixes:
     bug#336988 (thanks to Beiad Dalton <andy@wolfsinger.com>).
Files: 
 6789e8dc8f0a7573c60daba95d5ce98f 751 utils optional yaird_0.0.11-12.dsc
 d0fbcba8c2a46b065a47f7e520093306 29108 utils optional yaird_0.0.11-12.diff.gz
 b2204ec877dd8d8f1491ddccfd843691 173670 utils optional yaird_0.0.11-12_powerpc.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDc8run7DbMsAkQLgRAsGzAJ9o6ZOaRfTbrvwQN4I9+fWlXYJc0ACgk/RC
Bs8Ns9qzVRdRVhtNU1j4rJU=
=TssM
-----END PGP SIGNATURE-----



Reply to: