Bug#336636: fails on fstab line without optional fields
On Tue, Nov 01, 2005 at 02:59:06PM +0100, Jonas Smedegaard wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On Tue, 1 Nov 2005 14:48:47 +0100
> Mattia Dongili <malattia@linux.it> wrote:
>
> > [oh! I'm readding 336636@b.d.o]
> >
> > On Tue, Nov 01, 2005 at 01:53:01PM +0100, Jonas Smedegaard wrote:
> > > On Tue, 1 Nov 2005 12:03:09 +0100
> > > Mattia Dongili <malattia@linux.it> wrote:
> > >
> > > > It's legal for mount to have such entries so I'd suggest
> > > > decreasing that check.
> > >
> > > How do you come to this conclusion?
> >
> > do you mean the conclusion that it's legal for mount to accept
> > 3-fields lines?
>
> Right.
>
>
> > simple, I can mount and umount that fs with no
> > problems and the behaviour is the same as having 'defaults' as the
> > only option.
>
> Ah, so you mean "possible", not "legal".
I am not sure, but should yaird not use the fields it needs (only the two
first, and then maybe the third, or use some other method if not there, same
as for auto).
BTW, i just had an idea, but is maybe the way yaird does this not broken, and
it should use the mount output instead :
$ mount
/dev/hda3 on / type ext3 (rw,errors=remount-ro)
proc on /proc type proc (rw)
sysfs on /sys type sysfs (rw)
devpts on /dev/pts type devpts (rw,gid=5,mode=620)
tmpfs on /dev/shm type tmpfs (rw)
usbfs on /proc/bus/usb type usbfs (rw)
/dev/hda1 on /boot type ext2 (rw)
/dev/hda5 on /home type ext3 (rw)
Does that not provide all the info we need, and in a not-human-modified way
which makes parsing much easier. I think debian-installer also uses this
format, or /etc/mtab which seems to be the same.
Friendly,
Sven Luther
Reply to: