Bug#320798: This was a lame typo in kernel-package mkvmlinuz support patch :/
clone 320798
reassign 320798 kernel-package
thanks
Hi Manoj, the first bug report i wrote about this seems to have ended in bug
320055 for some strange reason, but i guess you read it, and i forwarded you a
personal mail with it too.
Anyway, i will put again the text of the above bug report :
------------------------
Hi Manoj, it seems the grep command in my last patch was bogus, as the
autobuilder failed to include the mkvmlinuz support, making 2.6.12-1 unusable
for me.
I am not sure what went wrong, but i have here a smallish patch which should
fix this. Not sure about the 2>&1 >/dev/null part though.
--- /usr/share/kernel-package/rules 2005-07-28 07:22:16.000000000 +0200
+++ rules 2005-08-01 19:04:56.000000000 +0200
@@ -2560,7 +2560,7 @@
debian/post-install; \
fi
ifeq ($(strip $(NEED_IMAGE_POST_PROCESSING)),YES)
- if test grep $(IMAGE_POST_PROCESS_TARGET) $(IMAGE_POST_PROCESS_DIR)/Makefile 2>&1 >/dev/null; then \
+ if test "`grep -c $(IMAGE_POST_PROCESS_TARGET) $(IMAGE_POST_PROCESS_DIR)/Makefile`" != 0; then \
$(MAKE) INSTALL_MKVMLINUZ=$(INSTALL_MKVMLINUZ_PATH) \
ARCH=$(KERNEL_ARCH) -C $(IMAGE_POST_PROCESS_DIR) $(IMAGE_POST_PROCESS_TARGET); \
fi
Maybe this could become :
if test "`grep -c $(IMAGE_POST_PROCESS_TARGET)
$(IMAGE_POST_PROCESS_DIR)/Makefile 2>/dev/null`" != 0; then \
Friendly,
Sven Luther
------------------------
Altough after a suggestion from Steve, this should rather be :
--- /usr/share/kernel-package/rules 2005-07-28 07:22:16.000000000 +0200
+++ rules 2005-08-01 19:04:56.000000000 +0200
@@ -2560,7 +2560,7 @@
debian/post-install; \
fi
ifeq ($(strip $(NEED_IMAGE_POST_PROCESSING)),YES)
- if test grep $(IMAGE_POST_PROCESS_TARGET) $(IMAGE_POST_PROCESS_DIR)/Makefile 2>&1 >/dev/null; then \
+ if test grep -q $(IMAGE_POST_PROCESS_TARGET) $(IMAGE_POST_PROCESS_DIR)/Makefile; then \
$(MAKE) INSTALL_MKVMLINUZ=$(INSTALL_MKVMLINUZ_PATH) \
ARCH=$(KERNEL_ARCH) -C $(IMAGE_POST_PROCESS_DIR) $(IMAGE_POST_PROCESS_TARGET); \
fi
Which i tested to give the right thing by hand, but didn't do a full kernel
build with it.
As i wrote you in personal email, if you don't have time to fix this, i am
ready to do an NMU or something, especially as we are in BSP this WE.
Mmm, i should probably downgrade the severity, but as this comes directly from
the bug against the kernel package, and i am not sure the BTS will do the
right thing to this bug report, i leave that to your discretion, and i hope
you won't take it bad.
Friendly,
Sven Luther
Reply to: