Re: Bug#291039: kernel-patch-debian-2.6.10: bashism in apply file

[Horms <horms@debian.org>]

tags 291039 +pending
tags 291107 +pending
thanks

On Fri, Jan 21, 2005 at 12:31:26PM +0900, Horms wrote:
> > With some good will you can read this from:
> >  http://www.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03
> > ---
> >   If the command substitution consists of a single subshell, such as:
> >   
> >   $( (command) )
> >   
> >   a conforming application shall separate the "$(" and '(' into two tokens
> >   (that is, separate them with white space). This is required to avoid any
> >   ambiguities with arithmetic expansion.
> > ---
> 
> Thanks for that clarification, I will make the relevant updates.

I have applied the following change to SVN which should rectify this
for 2.6.8, 2.6.9 and 2.6.10. 

-- 
Horms

Index: kernel-source-2.6.8-2.6.8/debian/apply
===================================================================
--- kernel-source-2.6.8-2.6.8/debian/apply	(revision 2332)
+++ kernel-source-2.6.8-2.6.8/debian/apply	(working copy)
@@ -157,7 +157,7 @@
 		exit 0
 	fi
 
-	for base in $((cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			if [ $srev -le $current_rev ]; then
@@ -168,7 +168,7 @@
 		fi
 	done
 elif [ "$current_rev" = "$upstream" ] || [ $target_rev -gt $current_rev ]; then
-	for base in $((cd $home/series/ && ls -d *) | sort -nt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -nt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			if [ $srev -gt $current_rev ] && [ $srev -le $target_rev ]; then
@@ -182,7 +182,7 @@
 	echo "Nothing to do, exiting."
 	exit 0
 elif [ $target_rev -lt $current_rev ]; then
-	for base in $((cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			# -gt because you don't want to unapply the target series
Index: kernel-source-2.6.9-2.6.9/debian/apply
===================================================================
--- kernel-source-2.6.9-2.6.9/debian/apply	(revision 2332)
+++ kernel-source-2.6.9-2.6.9/debian/apply	(working copy)
@@ -157,7 +157,7 @@
 		exit 0
 	fi
 
-	for base in $((cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			if [ $srev -le $current_rev ]; then
@@ -168,7 +168,7 @@
 		fi
 	done
 elif [ "$current_rev" = "$upstream" ] || [ $target_rev -gt $current_rev ]; then
-	for base in $((cd $home/series/ && ls -d *) | sort -nt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -nt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			if [ $srev -gt $current_rev ] && [ $srev -le $target_rev ]; then
@@ -182,7 +182,7 @@
 	echo "Nothing to do, exiting."
 	exit 0
 elif [ $target_rev -lt $current_rev ]; then
-	for base in $((cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			# -gt because you don't want to unapply the target series
Index: kernel-source-2.6.10-2.6.10/debian/apply
===================================================================
--- kernel-source-2.6.10-2.6.10/debian/apply	(revision 2332)
+++ kernel-source-2.6.10-2.6.10/debian/apply	(working copy)
@@ -157,7 +157,7 @@
 		exit 0
 	fi
 
-	for base in $((cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			if [ $srev -le $current_rev ]; then
@@ -168,7 +168,7 @@
 		fi
 	done
 elif [ "$current_rev" = "$upstream" ] || [ $target_rev -gt $current_rev ]; then
-	for base in $((cd $home/series/ && ls -d *) | sort -nt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -nt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			if [ $srev -gt $current_rev ] && [ $srev -le $target_rev ]; then
@@ -182,7 +182,7 @@
 	echo "Nothing to do, exiting."
 	exit 0
 elif [ $target_rev -lt $current_rev ]; then
-	for base in $((cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
+	for base in $( (cd $home/series/ && ls -d *) | sort -rnt- -k 2); do
 		srev=${base#*-}
 		if [ -n "$srev" ]; then
 			# -gt because you don't want to unapply the target series