[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#285767: initrd-tools: mkinitrd execute permission



On Wed, Dec 15, 2004 at 07:17:38PM +0530, Aneesh Kumar K.V wrote:
> Package: initrd-tools
> Version: 0.1.74
> Severity: normal
> 
> 
> Right now the debian/rules file does a simple cp of mkinitrd program. If
> mkinitrd  happen to be non executable it will end up the same way in
> ..deb also. I guess we should use install program  and specifiy the mode
> and ownership when installing mkinitrd.
> 
> ie instead of
> 
> cp mkinitrd debian/initrd-tools/usr/sbin
> 
> install -o root -g root -m 755 mkinitrd debian/initrd-tools/usr/sbin

Thanks,

Actually I think that the problem is potentially more extensive.
I propose the attached more comprehensive patch.

-- 
Horms
Index: debian/rules
===================================================================
--- debian/rules	(revision 1989)
+++ debian/rules	(working copy)
@@ -17,6 +17,7 @@
 	dh_testdir
 	dh_testroot
 	dh_clean
+	rm -f debian/version
 
 install: 
 	dh_testdir
@@ -25,10 +26,16 @@
 	dh_installdirs
 
 	sed 's/.* (\([^)]*\)).*/VERSION=\1/;q' debian/changelog \
-		> debian/initrd-tools/usr/share/initrd-tools/version
-	cp echo init linuxrc debian/initrd-tools/usr/share/initrd-tools
-	cp mkinitrd debian/initrd-tools/usr/sbin
-	cp mkinitrd.conf modules debian/initrd-tools/etc/mkinitrd
+		> debian/version
+	install -o root -g root -m 644 debian/version \
+		debian/initrd-tools/usr/share/initrd-tools/version
+	rm debian/version
+	install -o root -g root -m 644 \
+		echo init linuxrc debian/initrd-tools/usr/share/initrd-tools/
+	install -o root -g root -m 755 \
+		mkinitrd debian/initrd-tools/usr/sbin/
+	install -o root -g root -m 644 \
+		mkinitrd.conf modules debian/initrd-tools/etc/mkinitrd/
 
 # Build architecture-dependent files here.
 binary-arch: build install

Reply to: