Bug#206984: marked as done ([FIXED in 2.6] BLKRRPART should ignore whole-disk open)
Your message dated Sun, 03 Oct 2004 04:32:45 -0400
with message-id <E1CE1nR-0002r3-00@newraff.debian.org>
and subject line Bug#206984: fixed in kernel-source-2.6.8 2.6.8-7
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 24 Aug 2003 09:49:28 +0000
>From kon@iki.fi Sun Aug 24 04:49:26 2003
Return-path: <kon@iki.fi>
Received: from addr-213-216-217-115.suomi.net (Astalo.kon.iki.fi) [213.216.217.115]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 19qrV0-0006AD-00; Sun, 24 Aug 2003 04:49:26 -0500
Received: from kalle by Astalo.kon.iki.fi with local (Exim 4.20)
id 19qrUy-0008Jx-Mb; Sun, 24 Aug 2003 12:49:24 +0300
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: kernel: BLKRRPART should ignore whole-disk opens
Keywords: smartd,hdparm,partition table,MBR,refresh
X-Accept-Language: fi;q=1.0, en;q=0.9, sv;q=0.5, de;q=0.1
From: Kalle Olavi Niemitalo <kon@iki.fi>
Date: Sun, 24 Aug 2003 12:49:24 +0300
Message-ID: <87isono063.fsf@Astalo.kon.iki.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: Kalle Olavi Niemitalo <kon@iki.fi>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0
tests=BAYES_01,HAS_PACKAGE
version=2.53-bugs.debian.org_2003_8_17
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_8_17 (1.174.2.15-2003-03-30-exp)
Package: kernel
Version: 2.4.21-4
Severity: wishlist
I am unable to repartition my IDE disks when smartd is running.
Stopping smartd avoids this problem.
| # hdparm -z /dev/hde
|
| /dev/hde:
| BLKRRPART failed: Device or resource busy
| # ls -l /proc/$(pidof smartd)/fd
| total 0
| lrwx------ 1 root root 64 Aug 24 12:29 0 -> /dev/pts/4
| lrwx------ 1 root root 64 Aug 24 12:29 1 -> /dev/pts/4
| lrwx------ 1 root root 64 Aug 24 12:29 2 -> /dev/pts/4
| lrwx------ 1 root root 64 Aug 24 12:29 3 -> socket:[47988]
| lrwx------ 1 root root 64 Aug 24 12:29 4 -> /dev/hda
| lrwx------ 1 root root 64 Aug 24 12:29 5 -> /dev/hdc
| lrwx------ 1 root root 64 Aug 24 12:29 6 -> /dev/hde
| lrwx------ 1 root root 64 Aug 24 12:29 7 -> /dev/hdg
It seems to be that the BLKRRPART code (revalidate_hddisk in
linux-2.4.20/drivers/ide/hd.c, or ide_revalidate_disk in
linux-2.4.20/drivers/ide/ide.c) checks that the disk is open by
only one program, typically hdparm. This is presumably meant to
prevent altering partitions that are in use. However, I don't
see why the check should apply to whole-disk devices at all.
I mean, smartd doesn't care if partitions appear or disappear,
so having it running shouldn't stop me from altering the
partition table.
Please change the code so that it only checks whether any
partitions are in use. This way, the limit on the number of
references could also be changed from 1 to 0, as hdparm normally
uses the whole-disk device.
It would be even better if Linux actually read the new partition
table, compared it to the old one, and then refused the command
only if one of the *changed* partitions is in use. I presume
that is much more difficult to implement, however.
-- System Information
Debian Release: testing/unstable
Kernel Version: Linux Astalo 2.4.21-kon.astalo.1 #1 la elokuun 23. 01:05:31 EEST 2003 i686 GNU/Linux
---------------------------------------
Received: (at 206984-close) by bugs.debian.org; 3 Oct 2004 08:38:12 +0000
>From katie@ftp-master.debian.org Sun Oct 03 01:38:12 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1CE1si-00010r-00; Sun, 03 Oct 2004 01:38:12 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1CE1nR-0002r3-00; Sun, 03 Oct 2004 04:32:45 -0400
From: Andres Salomon <dilinger@voxel.net>
To: 206984-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#206984: fixed in kernel-source-2.6.8 2.6.8-7
Message-Id: <E1CE1nR-0002r3-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 03 Oct 2004 04:32:45 -0400
Delivered-To: 206984-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
X-CrossAssassin-Score: 4
Source: kernel-source-2.6.8
Source-Version: 2.6.8-7
We believe that the bug you reported is fixed in the latest version of
kernel-source-2.6.8, which is due to be installed in the Debian FTP archive:
kernel-doc-2.6.8_2.6.8-7_all.deb
to pool/main/k/kernel-source-2.6.8/kernel-doc-2.6.8_2.6.8-7_all.deb
kernel-patch-debian-2.6.8_2.6.8-7_all.deb
to pool/main/k/kernel-source-2.6.8/kernel-patch-debian-2.6.8_2.6.8-7_all.deb
kernel-source-2.6.8_2.6.8-7.diff.gz
to pool/main/k/kernel-source-2.6.8/kernel-source-2.6.8_2.6.8-7.diff.gz
kernel-source-2.6.8_2.6.8-7.dsc
to pool/main/k/kernel-source-2.6.8/kernel-source-2.6.8_2.6.8-7.dsc
kernel-source-2.6.8_2.6.8-7_all.deb
to pool/main/k/kernel-source-2.6.8/kernel-source-2.6.8_2.6.8-7_all.deb
kernel-tree-2.6.8_2.6.8-7_all.deb
to pool/main/k/kernel-source-2.6.8/kernel-tree-2.6.8_2.6.8-7_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 206984@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andres Salomon <dilinger@voxel.net> (supplier of updated kernel-source-2.6.8 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 03 Oct 2004 03:21:14 -0400
Source: kernel-source-2.6.8
Binary: kernel-source-2.6.8 kernel-doc-2.6.8 kernel-tree-2.6.8 kernel-patch-debian-2.6.8
Architecture: source all
Version: 2.6.8-7
Distribution: unstable
Urgency: medium
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Andres Salomon <dilinger@voxel.net>
Description:
kernel-doc-2.6.8 - Linux kernel specific documentation for version 2.6.8
kernel-patch-debian-2.6.8 - Debian patches to Linux 2.6.8
kernel-source-2.6.8 - Linux kernel source for version 2.6.8 with Debian patches
kernel-tree-2.6.8 - Linux kernel tree for building prepackaged Debian kernel images
Closes: 126482 153451 181350 206984 259056 267240 267342 270194 271852 272177 273474 274011
Changes:
kernel-source-2.6.8 (2.6.8-7) unstable; urgency=medium
.
* Fix VGA console on PReP systems (closes: #271852) (Jens Schmalzing).
.
* Really enable i915 agpgart support (Christoph Hellwig).
.
* Fix yet another bio leak (Christoph Hellwig).
.
* Switch /proc/sys/net/ipv4/tcp_default_win_scale default back to 0, there's
just too many broken system out there in the wild. (closes: #267342)
(Christoph Hellwig).
.
* Fix ata_piix controller numbering in combined mode (closes: #270194)
(Christoph Hellwig).
.
* Update tg3 driver (Christoph Hellwig).
.
* Update forcedeth driver to fix autoneg on 100Mbit cards (Christoph Hellwig).
.
* Fix ALSA module locking issue (closes: #259056) (Andres Salomon).
.
* Build-fix for 3c59x without pci (closes: #267240) (Maximilian Attems).
.
* Fix crash in ArcNet PCMCIA card (Maximilian Attems).
.
* Build-fix for airo on smp (Maximilian Attems).
.
* ACK old nmu (closes: #181350, #126482, #153451, #206984)
.
* Back out acpi-early caused problems on laptops, where APIC should not
be enabled. (closes: #272177, #273474, #274011) (Maximilian Attems)
Files:
970450a8551c5acbf3c5c0b30d9832ad 1645 devel optional kernel-source-2.6.8_2.6.8-7.dsc
d6b85b1910b841219bc2c76653be6fab 602945 devel optional kernel-source-2.6.8_2.6.8-7.diff.gz
b355bc84e45dc25db40df241ec1973e4 533300 devel optional kernel-patch-debian-2.6.8_2.6.8-7_all.deb
4336e90df29241a5804327d90cbd49eb 34913092 devel optional kernel-source-2.6.8_2.6.8-7_all.deb
eca9565121eefc887ea518fd006de113 21340 devel optional kernel-tree-2.6.8_2.6.8-7_all.deb
d08071368b7de28571f2f4cecacf62eb 6145666 doc optional kernel-doc-2.6.8_2.6.8-7_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: http://triplehelix.org/~joshk/pubkey_gpg.asc
iQIVAwUBQV+2HaOILr94RG8mAQLsCw/5AXgGwZmYLbC9MdbofG7rEfgKMwyNMWNa
rKHLshj0e6DHUHHW8wB/vnzRlofaF1qDETyx2NPR8hwKtuKzWlVR1nzr9aD5jFfk
LNySzA5rzIAAds4yg5wr/NddDcH90YXhQTz4t6ENDy018OM4FSJGKy++M91wPBbZ
ozZSL8LPt19cCi3Cd/8ClDOfozndQwa8JZxjx9X2xwULJ2AjPFxgzS9VoZCGGVob
9EfHmlIsYEaH8BeXJ6c1bHBPxf8ucIVtXS7yBxz+hCdOaYi6LUiB/ql/DRpAhMUh
vBQ1dMNMDVohvwUVnwV/W3uBFvRKB1hyIlnrrzXNwUOt2+UqBMbO+VLWYfa/HOs4
yo/N94wr7eZC85cPz9P17mFQ2my8ZOU7unMl4Vn4e9XD00UEtujsDf9xuFtfQ2s+
0Wb3UYKxjWnlr/+xViYmqyThSCG9dpWAIRlzbI+P7pEcwcvz+4MAS182zcq5Q1jQ
ns06BrxAWj35cwbpJyUX+dmBSjIWd1CkWs2q2CeKCN4gvT1OBAokszkoR8o1lIxs
+IdrMKGF0DYZWC4CHWNsu7J/g1aB3gxFcu3AQaqU1lrCasR/LHbi3cCk9EVrdvLI
e9Kszw6vbwRj1ftUqpJ/IBy2n4NpZAvzKOw1FgHW7Xm7nnqiIOdPLWEzfqfTqveN
i4iGpvj37/Y=
=xqB1
-----END PGP SIGNATURE-----
Reply to: