Bug#266892: marked as done (kernel panic with ingress scheduling)
Your message dated Wed, 25 Aug 2004 15:48:26 -0400
with message-id <E1C03kw-0006xB-00@newraff.debian.org>
and subject line Bug#266892: fixed in kernel-source-2.6.8 2.6.8-3
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 19 Aug 2004 15:17:25 +0000
>From ldm@apartia.org Thu Aug 19 08:17:24 2004
Return-path: <ldm@apartia.org>
Received: from zenon.apartia.fr (zenon.apartia.com) [82.66.93.83] (postfix)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BxofM-0001Oc-00; Thu, 19 Aug 2004 08:17:24 -0700
Received: by zenon.apartia.com (Postfix, from userid 1000)
id 868B9183931; Thu, 19 Aug 2004 17:17:21 +0200 (CEST)
Date: Thu, 19 Aug 2004 17:17:21 +0200
From: Louis-David Mitterrand <ldm@apartia.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: kernel panic with ingress scheduling
Message-ID: <[🔎] 20040819151721.GA31995@apartia.fr>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="SLDf9lqlvOQaIe6s"
Content-Disposition: inline
X-Reportbug-Version: 2.64
User-Agent: Mutt/1.5.6i
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--SLDf9lqlvOQaIe6s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: kernel-source-2.6.8
Version: 2.6.8-2
Severity: important
Tags: patch
A kernel panic is triggered when loading fiaif with htb scheduler
support.
Please see attached message from lkml with patch for details.
-- System Information:
Debian Release: 3.1
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (499, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.7-zenon
Locale: LANG=en_CA, LC_CTYPE=fr_FR@euro (ignored: LC_ALL set to en_US)
Versions of packages kernel-source-2.6.8 depends on:
ii binutils 2.15-1 The GNU assembler, linker and bina
ii bzip2 1.0.2-1 A high-quality block-sorting file
ii coreutils [fileutils] 5.2.1-2 The GNU core utilities
ii fileutils 5.2.1-2 The GNU file management utilities
-- no debconf information
--
ldm@apartia.fr
--SLDf9lqlvOQaIe6s
Content-Type: message/rfc822
Content-Disposition: inline
Path: news.free.fr!xref-2.proxad.net!10.13.0.21.MISMATCH!spooler3-1.proxad.net!feeder2-1.proxad.net!proxad.net!news.tele.dk!news.tele.dk!small.news.tele.dk!uio.no!nntp.uio.no!ifi.uio.no!internet-mailinglist
Newsgroups: fa.linux.kernel
Return-Path: <linux-kernel-owner+linux-kernel=40ifi.uio.no-s266817abuhoqmn@vger.kernel.org>
Original-Message-ID: <411F8B50.2020402@trash.net>
Original-Date: Sun, 15 Aug 2004 18:12:00 +0200
From: Patrick McHardy <kaber@trash.net>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
X-Accept-Language: en
MIME-Version: 1.0
To: lkml@lazy.shacknet.nu
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
"David S. Miller" <davem@redhat.com>
Subject: Re: [Panic] 2.6.8 and ingress scheduling
Original-References: <20040814175233.GA3617@lazy.shacknet.nu> <20040815130635.GA3703@lazy.shacknet.nu>
In-Reply-To: <20040815130635.GA3703@lazy.shacknet.nu>
Content-Type: multipart/mixed;
boundary="------------030503090501060902070806"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
X-MailScanner-Information: This message has been scanned for viruses/spam. Contact postmaster@uio.no if you have questions about this scanning
X-UiO-MailScanner: No virus found
X-UiO-Spam-info: not spam, SpamAssassin (score=0, required 12)
Organization: Internet mailing list
Date: Sun, 15 Aug 2004 20:10:21 GMT
Message-ID: <fa.e29vo0k.12ku7pm@ifi.uio.no>
References: <fa.idmtofe.1gieeio@ifi.uio.no>
Xref: news.free.fr fa.linux.kernel:347197
This is a multi-part message in MIME format.
--------------030503090501060902070806
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
lkml@lazy.shacknet.nu wrote:
>hello again,
>
>
>
>>the last line (filter add) in the "wondershaper" script does sth. to the
>>kernel, that lets it panic on receiving network packets.
>>
>>
>
>actually, the last _two_ commands set up the kernel for panic. please
>see attached script; running should produce this console message:
>
>
Fixed by this patch. qdisc_data was only aligned correctly in
qdisc_create_dflt(),
not qdisc_create() which resulted in memory corruption.
Regards
Patrick
--------------030503090501060902070806
Content-Type: text/x-patch;
name="qdisc-align.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="qdisc-align.diff"
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/08/15 18:08:13+02:00 kaber@coreworks.de
# [PKT_SCHED]: cacheline-align qdisc data in qdisc_create()
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/sched/sch_api.c
# 2004/08/15 18:04:27+02:00 kaber@coreworks.de +13 -8
# [PKT_SCHED]: cacheline-align qdisc data in qdisc_create()
#
diff -Nru a/net/sched/sch_api.c b/net/sched/sch_api.c
--- a/net/sched/sch_api.c 2004-08-15 18:09:36 +02:00
+++ b/net/sched/sch_api.c 2004-08-15 18:09:36 +02:00
@@ -389,7 +389,8 @@
{
int err;
struct rtattr *kind = tca[TCA_KIND-1];
- struct Qdisc *sch = NULL;
+ void *p = NULL;
+ struct Qdisc *sch;
struct Qdisc_ops *ops;
int size;
@@ -407,12 +408,18 @@
if (ops == NULL)
goto err_out;
- size = sizeof(*sch) + ops->priv_size;
+ /* ensure that the Qdisc and the private data are 32-byte aligned */
+ size = ((sizeof(*sch) + QDISC_ALIGN_CONST) & ~QDISC_ALIGN_CONST);
+ size += ops->priv_size + QDISC_ALIGN_CONST;
- sch = kmalloc(size, GFP_KERNEL);
+ p = kmalloc(size, GFP_KERNEL);
err = -ENOBUFS;
- if (!sch)
+ if (!p)
goto err_out;
+ memset(p, 0, size);
+ sch = (struct Qdisc *)(((unsigned long)p + QDISC_ALIGN_CONST)
+ & ~QDISC_ALIGN_CONST);
+ sch->padded = (char *)sch - (char *)p;
/* Grrr... Resolve race condition with module unload */
@@ -420,8 +427,6 @@
if (ops != qdisc_lookup_ops(kind))
goto err_out;
- memset(sch, 0, size);
-
INIT_LIST_HEAD(&sch->list);
skb_queue_head_init(&sch->q);
@@ -470,8 +475,8 @@
err_out:
*errp = err;
- if (sch)
- kfree(sch);
+ if (p)
+ kfree(p);
return NULL;
}
--------------030503090501060902070806--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--SLDf9lqlvOQaIe6s--
---------------------------------------
Received: (at 266892-close) by bugs.debian.org; 25 Aug 2004 19:53:25 +0000
>From katie@ftp-master.debian.org Wed Aug 25 12:53:25 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1C03pl-0005Xw-00; Wed, 25 Aug 2004 12:53:25 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1C03kw-0006xB-00; Wed, 25 Aug 2004 15:48:26 -0400
From: Sven Luther <luther@debian.org>
To: 266892-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#266892: fixed in kernel-source-2.6.8 2.6.8-3
Message-Id: <E1C03kw-0006xB-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 25 Aug 2004 15:48:26 -0400
Delivered-To: 266892-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
X-CrossAssassin-Score: 8
Source: kernel-source-2.6.8
Source-Version: 2.6.8-3
We believe that the bug you reported is fixed in the latest version of
kernel-source-2.6.8, which is due to be installed in the Debian FTP archive:
kernel-doc-2.6.8_2.6.8-3_all.deb
to pool/main/k/kernel-source-2.6.8/kernel-doc-2.6.8_2.6.8-3_all.deb
kernel-patch-debian-2.6.8_2.6.8-3_all.deb
to pool/main/k/kernel-source-2.6.8/kernel-patch-debian-2.6.8_2.6.8-3_all.deb
kernel-source-2.6.8_2.6.8-3.diff.gz
to pool/main/k/kernel-source-2.6.8/kernel-source-2.6.8_2.6.8-3.diff.gz
kernel-source-2.6.8_2.6.8-3.dsc
to pool/main/k/kernel-source-2.6.8/kernel-source-2.6.8_2.6.8-3.dsc
kernel-source-2.6.8_2.6.8-3_all.deb
to pool/main/k/kernel-source-2.6.8/kernel-source-2.6.8_2.6.8-3_all.deb
kernel-tree-2.6.8_2.6.8-3_all.deb
to pool/main/k/kernel-source-2.6.8/kernel-tree-2.6.8_2.6.8-3_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 266892@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Sven Luther <luther@debian.org> (supplier of updated kernel-source-2.6.8 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Wed, 25 Aug 2004 17:40:07 +0200
Source: kernel-source-2.6.8
Binary: kernel-source-2.6.8 kernel-doc-2.6.8 kernel-tree-2.6.8 kernel-patch-debian-2.6.8
Architecture: source all
Version: 2.6.8-3
Distribution: unstable
Urgency: high
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: Sven Luther <luther@debian.org>
Description:
kernel-doc-2.6.8 - Linux kernel specific documentation for version 2.6.8
kernel-patch-debian-2.6.8 - Debian patches to Linux 2.6.8
kernel-source-2.6.8 - Linux kernel source for version 2.6.8 with Debian patches
kernel-tree-2.6.8 - Linux kernel tree for building prepackaged Debian kernel images
Closes: 255931 256757 256871 257763 258061 261784 266731 266892 267338 267464
Changes:
kernel-source-2.6.8 (2.6.8-3) unstable; urgency=high
.
* Suggest libqt3-dev for xconfig (closes: #261784) (Andres Salomon).
.
* Update documentation (Christoph Hellwig).
.
* Add bio_uncopy_user leak fix from Kurt Garloff (closes: #256871)
(Christoph Hellwig).
.
* Update scsi blacklist for USB multi card readers (Christoph Hellwig).
.
* Claim we're Windows (TM) to ACPI to work around broken BIOSes
(Christoph Hellwig).
.
* Fix early boot crash on some oldworld Power Macs. (closes: #266731)
(Christoph Hellwig).
.
* Add qdisc crash fix (closes: #266892) (Christoph Hellwig).
.
* Replace the drivers-scsi-sym53c8xx_revert workaround with
drivers-scsi-sym_2-dv-hang, which is a proper fix for the hang
(dann frazier).
.
* Enter ACPI mode earlier (closes: #258061) (Christoph Hellwig).
.
* Add a comment about the Adaptec firmware rebuild situation to
README.Debian (closes: #256757) (Christoph Hellwig).
.
* Update bio_uncopy_user-memleak to really fix the problem
(closes: #267464, #267338) (Christoph Hellwig).
.
* Update list of safe SCSI commands for SG_IO to match 2.6.9-rc1
(Christoph Hellwig).
.
* Update CCISS driver (Christoph Hellwig).
.
* Add minix block accounting fix (Christoph Hellwig).
.
* Fix nfsd to not errornously return ESTALE on failed permission check
(closes: #255931) (Christoph Hellwig).
.
* Fix SHM segment count limit off by one (Christoph Hellwig).
.
* Modularize xfrm_tunnel (Christoph Hellwig).
.
* Add small ACPI fix that makes speedstep work on some Centrino Laptops
(closes: #257763) (Christoph Hellwig).
Files:
e11d871c94e4c2b80ea109ec281dc0a5 911 devel optional kernel-source-2.6.8_2.6.8-3.dsc
d192fad5d8c8534399539270da0f57c0 546373 devel optional kernel-source-2.6.8_2.6.8-3.diff.gz
04d63a08fbf900ef2fa305cc02ffd281 200988 devel optional kernel-patch-debian-2.6.8_2.6.8-3_all.deb
046d99bea7140fabb523d919ea9d5a9e 302996 devel optional kernel-tree-2.6.8_2.6.8-3_all.deb
d6c04d060fc960b8d1508d2591e7047d 34904884 devel optional kernel-source-2.6.8_2.6.8-3_all.deb
39fe9e5c1746d42f3c8fe78f27745fe9 6144040 doc optional kernel-doc-2.6.8_2.6.8-3_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFBLNnk2WTeT3CRQaQRAhlmAJ0WVH/vM3Md/zYovrmGmS1z528+rgCgooH8
i3y541uLYfJJCuEIR8fBMTs=
=gd5r
-----END PGP SIGNATURE-----
Reply to: