Re: [xdg-desktop-portal-kde] KDE Bug 402077: SaveFile does not set the current_name

[Sedat Dilek <sedat.dilek@gmail.com>]

Hi Sandro,

you are absolutely right with doing this the "Debian-way" by sending a
bug-report.

I will create a bug-report this afternoon with all relevant
informations and patches.

I know of <salsa.d.o> and I guess I have to clone the
xdg-desktop-portal-kde Git repo and then do a merge/pull-request (from
e.g. my GitHub-account)?
Let me see.

Thanks:

Regards,
- Sedat (dileks) -


On Wed, Nov 27, 2019 at 9:48 PM Sandro Knauß <hefee@debian.org> wrote:
>
> Hey,
>
> first thanks for all the work you put into that.
>
> But first your approch to fix that, it not the way this is done on Debian. Your
> request should result in an bugreport against  xdg-desktop-portal-kde where
> you add your patch as solution.
>
> That way the maintainer will know about the issue and can decide what to do.
>
> If you want to help further to get this fixed, you can create a merge request
> on salsa:
>
> https://salsa.debian.org/qt-kde-team/kde/xdg-desktop-portal-kde/merge_requests
>
> We can even think about a fix for Debian stable.
>
> Anyways, if you have any question, feel free to ask.
>
> hefee
>
>
> > I am here on Debian/testing AMD64.
> >
> > The KDE file selection dialog when running Firefox-ESR with
> > "GTK_USE_PORTAL=1" does not work properly with SaveFile.
> >
> > For example when I want to save a PDF from a website the original
> > filename is not offered/displayed in the SaveFile-Dialog-Box.
> >
> > For details see KDE Bug 402077 "SaveFile does not set the current_name" in
> > [1].
> >
> > There exists a patch for xdg-desktop-portal-kde 5.14 branch in [2].
> > [2] applies cleany to xdg-desktop-portal-kde (5.14.5-2) sources.
> >
> > Is it possible you can apply it?
> >
> > Thanks in advance.
> >
> > Best regards,
> > - Sedat .-
> >
> > [1] https://bugs.kde.org/show_bug.cgi?id=402077
> > [2] https://phabricator.kde.org/D18378
> >
> > P.S.: Details xdg-desktop-portal-kde
> >
> > root# LC_ALL=C apt-cache policy xdg-desktop-portal-kde
> > xdg-desktop-portal-kde:
> >   Installed: 5.14.5-2
> >   Candidate: 5.14.5-2
> >   Version table:
> >  *** 5.14.5-2 100
> >          99 http://deb.debian.org/debian testing/main amd64 Packages
> >          99 http://deb.debian.org/debian unstable/main amd64 Packages
> >         100 /var/lib/dpkg/status
> >      5.14.5-1 500
> >         500 http://deb.debian.org/debian buster/main amd64 Packages
> >
> > user$ diff -uprN /usr/share/applications/firefox-esr.desktop
> > ~/.local/share/applications/firefox-esr.desktop | egrep 'Desktop|Exec'
> > +[Desktop Action new-private-window]
> > +Exec=GTK_USE_PORTAL=1 /usr/lib/firefox-esr/firefox-esr --private-window %u
> > +[Desktop Action new-window]
> > +Exec=GTK_USE_PORTAL=1 /usr/lib/firefox-esr/firefox-esr --new-window %u
> >  [Desktop Entry]
> > +Exec=GTK_USE_PORTAL=1 /usr/lib/firefox-esr/firefox-esr %u
> > -Exec=/usr/lib/firefox-esr/firefox-esr %u
> >
> > - EOT -
>