Re: Could you check my works for the node-hoek?
Hello Praveen,
On 7/18/25 3:24 오후, Pirate Praveen wrote:
> [copying debian-js]
>
> On 7/18/25 12:20 PM, Yunseong Kim wrote:
>> Hi
>>
>> I'm Yunseong Kim. As per your review on the IRC channel, I’ve updated the Salsa
>> repository accordingly. I’d appreciate it if you could take a moment to review the
>> changes.
>> Link: https://salsa.debian.org/ysk/node-hoek
>
> Looks good to me. For major updates like this (see https://semver.org to learn more about it) we need to make sure packages that depend on the package we are updating (reverse dependencies) does not break. You can ask me later how to find this (once you are confident with minor version updates). For this package I ran the tests for reverse dependencies and they pass. So I have uploaded it.
Sounds Great, Thank you for the review!
> You can try to update node-pretty-ms now. You can take help from Michelle and Giyeon. If you are not able to fix the test failures after trying for some time, let me know I can help.
Sure, We can try to working for the node-pretty-ms.
I've been reviewing the CI issue on the Michelle's branch.
Thank you!
Yunseong
Reply to: