[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Call for testing yarnpkg 4 (Re: RFS: node-yarnpkg (update))





On 29/10/23 3:54 pm, Pirate Praveen wrote:


On 13/10/23 8:26 PM, Israel Galadima wrote:
On Fri, 13 Oct 2023 at 13:57, Pirate Praveen <praveen@onenetbeyond.org <mailto:praveen@onenetbeyond.org>> wrote:

    I think I use coma separated list, but probably the other option
    work too.


Thanks, I've fixed everything.

Thanks to great work by Israel and other outreachy interns in the past, we have a yarnpkg in the archive that is built with well maintained build and runtime dependendencies (we can finally get rid of obsolete node-request from the archive). We can also stop maintaining patches to make it build with newer build depends like babel 7.

We also have corepack, which is kind of a meta package manager - package manager to install package managers!! (no surprise to people who know nodejs). corepack can install npm, yarn or pnpm.

Currently yarnpkg 4 is in experimental, I would like these things completed before we upload it to unstable.

1. Test the yarnpkg from experimental a bit, for example try to use it in gitlab

I added a patch to gitlab (https://salsa.debian.org/ruby-team/gitlab/-/commit/48c96037d26bbe9ff146b72a4bf4bc0fc518ee24) to use yarnpkg set version berry conditionally only when yarn major version is 1.

With yarnpkg installed from experimental, this worked fine.

Installing node modules...
➤ YN0065: Yarn will periodically gather anonymous telemetry: https://yarnpkg.com/advanced/telemetry
➤ YN0065: Run yarn config set --home enableTelemetry 0 to disable

➤ YN0000: · Yarn 4.0.0-rc.53.git.20231013.hash-0eb03e41
➤ YN0000: ┌ Resolution step
➤ YN0085: │ + @apollo/client@npm:3.5.10, @babel/core@npm:7.19.0, and 1849 more.
➤ YN0000: └ Completed in 1m 33s
➤ YN0000: ┌ Post-resolution validation
➤ YN0060: │ babel-jest is listed by your project with version 28.1.3, which doesn't satisfy what @vue/vue3-jest requests (^29.0.0). ➤ YN0060: │ jest is listed by your project with version 28.1.3, which doesn't satisfy what @vue/vue3-jest requests (^29.0.0). ➤ YN0060: │ vue is listed by your project with version 2.7.14, which doesn't satisfy what @vue/apollo-components requests (3.2.47). ➤ YN0060: │ worker-loader is listed by your project with version 2.0.0, which doesn't satisfy what pdfjs-dist requests (^3.0.8). ➤ YN0086: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0013: │ 1850 packages were added to the project (+ 784.94 MiB).
➤ YN0000: └ Completed in 3m 54s
➤ YN0000: ┌ Link step
➤ YN0007: │ core-js@npm:3.30.2 must be built because it never has been before or the last one failed ➤ YN0007: │ nodemon@npm:2.0.19 must be built because it never has been before or the last one failed ➤ YN0007: │ bootstrap-vue@npm:2.23.1 must be built because it never has been before or the last one failed ➤ YN0007: │ core-js-pure@npm:3.6.5 must be built because it never has been before or the last one failed ➤ YN0007: │ root-workspace-0b6124@workspace:. must be built because it never has been before or the last one failed
➤ YN0000: └ Completed in 11s 524ms
➤ YN0000: · Done with warnings in 5m 39s

Only other reverse dependency is python3-django-yarnpkg and we should file a transition bug for them to test the new version and adapt as required, they may need to enable node-modules linker as there won't be a node_modules directory anymore.

Also mention about corepack yarn if they want to stay with yarn 1.

2. Document how to use corepack yarn or node_modules plugin to get yarn 1.x

The following code will restore node_modules folder,
if ! grep nodeLinker .yarnrc.yml >/dev/null; then echo "nodeLinker: \"node-modules\"" >>.yarnrc.yml; fi

3. Create a NEWS file in yarnpkg to mention how to get yarn 1 behavior, either by using corepack or by enabling node_modules plugin.

Use the above code if they just want the node_modules folder or use 'corepack yarn' if they want yarn 1.x.

Add these two options to debian/README.Debian and then reference it in the NEWS file.

So please test yarnpkg from experimental and report any problems you notice.

Regards.

Attachment: OpenPGP_0x8F53E0193B294B75.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: