|
Hi, Pierre Gruet > There seems to be something wrong at the tip of the master branch, as it
> contains files (e.g. PROPOSAL.html) which are not in the upstream
> tarball I get by running uscan from the source dir. Could you please fix it? > Also I see there was no commit on the pristine-tar branch related to
> this new version, please handle the relevant pristine-tar option when
> using git-buildpackage. The upstream branch commit needs to be fixed , its my mistake. I missed the archive version[1] with another tagged version from github[2], the latter one includes three more items. They are .github, .travis.yml and PROPOSAL.html. I will upload again after fixing all the problems. > It is fine to ignore the tests that need junit-clptr (which is the case
> only in one class as I can see), but if I understand correctly what you
> write, all other tests are successful? If so, one should only skip the
> problematic class by patching pom.xml (see third answer in [0] with the
> maven-surefire-plugin configuration) instead of skipping all the tests. > Also keep what you changed in debian/maven.ignoreRules, that's OK. Yes all the test cases passed.
I patched the pom.xml according to your advice. --- libcommons-validator-java-1.7.orig/pom.xml +++ libcommons-validator-java-1.7/pom.xml @@ -319,6 +319,9 @@ versions after 2.21.0 and before 3.0-M4 (but only on Windows!) Use the command-line instead to ensure the property is set early enough --> + <excludes> + <exclude>**/DomainValidatorStartupTest.java</exclude> + </excludes> <argLine>-Djava.locale.providers=COMPAT,SPI</argLine> </configuration> </plugin> This test class should be skipped. But it failed to build, the java compiler seems to do some compile time check and aborted building because class not found. I tried to append the below line to debian/maven.properties. test='!DomainValidatorStartupTest.java' But , it make no difference. I got stuck, could any one give me some suggestion. [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:testCompile (default-testCompile) on project commons-validator:
Compilation failure: Compilation failure: [ERROR] /<<PKGBUILDDIR>>/src/test/java/org/apache/commons/validator/routines/DomainValidatorStartupTest.java:[28,40] package org.bitstrings.test.junit.runner
does not exist [ERROR] /<<PKGBUILDDIR>>/src/test/java/org/apache/commons/validator/routines/DomainValidatorStartupTest.java:[35,11] cannot find symbol [ERROR] symbol: class ClassLoaderPerTestRunner [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles [1]
https://archive.apache.org/dist/commons/validator/source/commons-validator-1.7-src.tar.gz [2] https://github.com/apache/commons-validator/archive/refs/tags/VALIDATOR_1_7.tar.gz
发件人:
Pierre Gruet Control: tags -1 moreinfo Hi, On Thu, 19 Jan 2023 07:44:05 +0000 min sun <sunmin89@outlook.com> wrote: > > Package: sponsorship-requests > Severity: normal > > Dear mentors, > > I am looking for a sponsor for my package "libcommons-validator-java": > > * Package name : libcommons-validator-java > Version : 1:1.7-1 > Upstream contact : http://commons.apache.org/validator/ > * URL : https://commons.apache.org/proper/commons-validator/ > * License : Apache-2.0 > * Vcs : https://salsa.debian.org/java-team/libcommons-validator-java > Section : java > > The source builds the following binary packages: > > libcommons-validator-java - ease and speed development and
maintenance of validation rules > libcommons-validator-java-doc - API documentation for Commons Validator > > To access further information about this package, please visit the
following URL: > > https://mentors.debian.net/package/libcommons-validator-java/ > > Alternatively, you can download the package with 'dget' using this
command: > > dget -x
https://mentors.debian.net/debian/pool/main/libc/libcommons-validator-java/libcommons-validator-java_1.7-1.dsc > > Changes since the last upload: > > libcommons-validator-java (1:1.7-1) UNRELEASED; urgency=medium > . > * Team upload. > * New upstream release. > * Add commons-csv-java as new dependency. > * Skip running the tests. > There seems to be something wrong at the tip of the master branch, as it
contains files (e.g. PROPOSAL.html) which are not in the upstream
tarball I get by running uscan from the source dir. Could you please fix it? Also I see there was no commit on the pristine-tar branch related to
this new version, please handle the relevant pristine-tar option when
using git-buildpackage. > > This new version needs a test dependency called junit-clptr which is
not ported to debian currently, I don’t
know how to handle this issue and just ignore it,and have to skip the test. > > I tried to enable the test and build locally with bellow command: > dpkg-buildpackage -us -uc > > The test results shows that : > > [WARNING] Tests run: 25, Failures: 0, Errors: 0, Skipped: 1, Time
elapsed: 0.025 s - in
org.apache.commons.validator.routines.EmailValidatorTest > > [WARNING] Tests run: 576, Failures: 0, Errors: 0, Skipped: 1 > > I think it is harmless to disable the test for now. It is fine to ignore the tests that need junit-clptr (which is the case
only in one class as I can see), but if I understand correctly what you
write, all other tests are successful? If so, one should only skip the
problematic class by patching pom.xml (see third answer in [0] with the
maven-surefire-plugin configuration) instead of skipping all the tests. Also keep what you changed in debian/maven.ignoreRules, that's OK. > > I’m not familiar with java packaging
and any suggestion or advice is welcome. I hope this helps :) > > Regards, > -- > sun min > Cheers, --
Pierre [0]
https://stackoverflow.com/questions/835705/is-there-a-way-to-skip-only-a-single-test-in-maven |