Hi Felix, On Sat, Oct 19, 2019 at 08:13:34PM +0200, Felix Natter wrote: > hello Tony, > > as discussed, here are two more dependencies of freeplane-1.7.10 > (darcula and its dependency iconloader from the same author). > > 1. https://salsa.debian.org/java-team/libiconloader-java > > The upstream is at https://github.com/bulenkov/iconloader.git, which is > not active and has no releases, so I packaged git HEAD (@Markus: > unfortunately there is no alternative to this). > > It uses a simple ant build system. > > JDK11 does not have sun.reflect.ConstructorAccessor (at compile time), > so I replaced it with new String(...) (which is used by upstream if > ConstructorAccessor cannot be instantiated). Could you please review > this patch [1]? > I also disabled apple code (third patch). > > [1] https://salsa.debian.org/java-team/libiconloader-java/blob/master/debian/patches/02_replace_ConstructorAccessor.patch In order to preserve the semantics of createShared(), maybe it's better to go ahead and instantiate an array of char[] and then return that cast to a String? (I'm not sure what the original code was hoping to accomplish.) Then the underlying storage is mutable if some application really expects the underlying bytes to be shared. Or we could go with your patch and adjust if we encounter any problems. One other comment about libiconloader-java... It would be nice to add .idea to Files-Excluded in debian/copyright and regenerate the orig.tar.gz. The .idea files can be regenerated IntelliJ if needed. > 2. https://salsa.debian.org/java-team/darcula I haven't looked at this yet. Cheers, tony
Attachment:
signature.asc
Description: PGP signature