[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#925473: tomcat9: sysvinit script missing (Policy §9.11¶2 “must”)



Hi Emmanuel,

>What is the issue with the dependency on systemd?

Most people using Debian without systemd have APT pinning or other
measures in place that prevent the systemd package, which ships the
systemd-sysusers binary (and service?), from being installed, in
order to not sneakily being converted to systemd (it did happen).
I only know of the elogind case (which most likely will only be
available in bullseye) as one where non-systemd init but systemd
binaries will be used.

What is the issue with using adduser, which is the standard Debian
tool doing the same job, instead? After all, depending on systemd
just to create a system user and group is very heavy-weight.

>> diff --git a/debian/tomcat9.postinst b/debian/tomcat9.postinst
>> index 55fb55c2..8edcfc5c 100644
>> --- a/debian/tomcat9.postinst
>> +++ b/debian/tomcat9.postinst
>> @@ -5,6 +5,7 @@
>>
>>  set -e
>>
>> +# Note these are no longer configurable (as of commit 243d00dc688ea47f4c7cde570ccaaa70efe269bf)
>>  TOMCAT_USER="tomcat"
>>  TOMCAT_GROUP="tomcat"
>
>The comment doesn't add much value. The non configurable user/group is
>already documented in the changelog.

OK, removed.

>If systemd-sysusers can't be used directly I prefer an inline code to an
>external file.

OK, reverted.

(I kept the check whether the user exists as first check, though;
there’s no need to try to create it over and over on every upgrade
on systemd systems either, and since its presence is needed for the
non-systemd case, it can be made use of in the systemd case, too.)


Did you have a chance to test this on a buster/systemd Debian?
I don’t currently have such a machine existing in a meaningful
way. (Granted, I could probably cobble together some test VM,
but I’m sure you have something at hand.)

I tried one with sysvinit, but it turns out that the software
does not yet work under Tomcat 9, so I had to revert the VM to
Tomcat 8; it did start and write logs with sensible ownership
and permission, though.

Thanks,
//mirabilos
--  
When he found out that the m68k port was in a pretty bad shape, he did
not, like many before him, shrug and move on; instead, he took it upon
himself to start compiling things, just so he could compile his shell.
How's that for dedication. -- Wouter, about my Debian/m68k revival


Reply to: