Re: Bug#832985: RFS: svgsalamander/1.0.0+dfsg1-1
Sebastiaan Couwenberg <sebastic@xs4all.nl> writes:
> Hi Felix,
hello Bas,
thank you very much for the detailed review.
> I've had a look at your package and some comments follow. In general the
> package looks good, but there is room for improvement.
>
> Please consider bumping the debhelper compatibility to 9.
done + cme fix dpkg-control.
> Also change the LGPL-2.0 shortname to LGPL-2+ to better reflects the "or
> (at your option) any later version" clause.
done.
> The Forwarded header in
> 0004-Use-system-awt-gradient-instead-of-the-embedded-batik.patch &
> 0006-modify-broken-upstream-pom.patch can also be improved. For the
> former "not-needed" is more appropriate than "no" with note, not-needed
> is probably also appropriate for the latter.
done. Upstream knows about the broken POM (0006), so I put in
not-needed there.
> The README.source should be updated to reflect the change to GitHub
> tarballs.
done. I put in both "signatures", since some stuff is from Nicolas.
[...]
See the get-orig-source target for debian/rules to fetch a clean tarball.
-- Felix Natter <fnatter@gmx.net> Sat, 6 Aug 2016 15:41:00 +0200
-- Nicolas Dandrimont <nicolas.dandrimont@crans.org>, Sun, 6 Mar 2011 15:07:47 +0100
> Consider adding the --parallel option to dh in debian/rules to enable
> the use of parallel builds with DEB_BUILD_OPTIONS="parallel=<N>".
done. (although compilation takes less than a few seconds).
> The watch file can also be improved to handle common issues [0], like
> the attached version for example.
I added your watch file, thank you.
So that I understand this:
- version=3 is preferred
- make archive type variable
- make dversionmangle more general (backports etc.)
- make uversionmangle more general:
+uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha)\d*)$/$1~$2/;s/RC/rc/,\
--> is this best practice for github tarballs? Otherwise I think this is
difficult because every upstream project has different terminology.
--> Maybe the uscan man page should be extended regarding this?
(it contains a github example hard-coded for tar.gz)
> Also consider adding upstream metadata [1].
I added this.
New Changelog:
svgsalamander (1.0.0+dfsg1-1) unstable; urgency=medium
* New upstream version, now on github
* Update README.source (source pulled from github release)
* Add watch file (from Sebastiaan Couwenberg <sebastic@xs4all.nl>)
* Use Files-Excluded: instead of repack script
* Do not call netbeans ant targets by setting mkdist.disabled
* Fix the pom to be installed by maven-repo-helper (version=1.0.0, no deps)
* Update standards-version to 3.9.8 (no changes)
* Fix license short names (BSD->BSD-3-clause, LGPL-2.0->LGPL-2+)
* Fix lintians
* Add DEP3 patch headers
* Add upstream metadata
* Bump debhelper compat to 9
-- Felix Natter <fnatter@gmx.net> Sat, 06 Aug 2016 16:16:37 +0200
Many Thanks and Best Regards,
--
Felix Natter
Reply to: