Re: libmnemonicsetter-java: Please review

[Felix Natter <fnatter@gmx.net>]

Markus Koschany <apo@debian.org> writes:

> Hi Felix,
>
> Am 07.05.2016 um 16:39 schrieb Felix Natter:
>> hello debian-java,
>> 
>> I have a very simple gradle package (libmnemonicsetter-java) which will
>> be needed for freeplane-1.5.9 (and simplyhtml-0.16.17), to be released
>> in a few weeks:
>>   http://anonscm.debian.org/cgit/pkg-java/libmnemonicsetter-java.git
>> 
>> Current freeplane does not use it, so it can be uploaded to
>> unstable already.
>> 
>> Does anyone want to review this?
>> 
>
> The package looks good to me. Some minor nitpicks:

hello Markuks,

> I would remove maven.cleanIgnoreRules and maven.publishedRules because
> they are empty.
>
> debian/watch: version should be 4 now.
>
> debian/control:
>
> text description: s/swing/Swing and s/java/Java and s/java7/Java 7

Fixed. Thanks for the review and for sponsoring.

Cheers and Best Regards,
-- 
Felix Natter