Control: tags -1 moreinfo
Am 22.12.2015 um 22:45 schrieb Jerome Benoit:
> Package: sponsorship-requests
> Severity: normal
>
> Dear Mentors:
>
> I am looking for a sponsor for the package openviewerfx [1],
> a Java library to manipulate PDF material (which is the
> successor of the jpedal java library).
Hello Jerome,
Here are some initial remarks:
Your package fails to build from source with this error message.
src/org/jpedal/io/CertificateReader.java:69: error: method getContent in
class RecipientInformation cannot be applied to given types;
envelopedData = recipientInfo.getContent(key,
provider);
^
required: Recipient
found: Key,String
reason: actual and formal argument lists differ in length
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
debian/rules:17: recipe for target 'override_jh_build-indep' failed
Where exactly did you download the sources from? I understand that they
didn't release a new version back then, but you should always ensure
that someone can compare the original sources with your tarball by
either describing the necessary steps in README.source or by providing a
get-orig-source target or both. By the way it seems they have released a
new version on sourceforge.net now.
http://sourceforge.net/projects/openviewerfx/files/2015_12/
debian/repack:
There is nothing wrong with a separate script for repacking the sources
but you might also want to consider to use the Files-Excluded mechanism
with debian/copyright format 1.0 which is IMO a better and standardized
solution which avoids the reinvention of the wheel for every new
package. For custom get-orig-source targets I can also recommend:
https://wiki.debian.org/onlyjob/get-orig-source
Since openviewerfx is an application, you must provide some sort of
wrapper to launch the Java app. You can either use java-wrappers (See
example [1] and [2]) or your package should depend on jarwrapper.
debian/control:
Please use https for the Vcs-Browser field.
I get into more details when you fix the compile issue and provide a way
to download and compare the original sources with your tarball.
Regards,
Markus
[1]
https://sources.debian.net/src/mediathekview/10-2/debian/bin/mediathekview/
[2]
https://sources.debian.net/src/electric/9.06%2Bdfsg-1/debian/bin/electric/
Attachment:
signature.asc
Description: OpenPGP digital signature