Re: Review of cmdreader package
Ok, that fixed that issue. :) I think that's worth reporting a bug in ivy,
could you send in a report based on your experience and fix here? I suppose
the 'ivy' package could just provide the right symlink, and then ant would
find ivy.jar automatically.
After that, there was one more missing Build-Depends, ant-optional for JUnit
support, then it built for me.
I fixed a lintian error, complaining about "Architecture: any". That means
the package can be built for any arch, but will have arch-specific binaries.
"Architecture: all" means the binary will run on all arches, like Java .jars do.
I pushed my commits and uploaded this package.
.hc
Komal Sukhani:
> Hi Hans,
>
> Ant was searching for ivy.jar in /usr/share/ant/lib and
> -/tmp/buildd/.ant/lib. This was causing the problem.
> I have corrected rules file by providing location of ivy.jar to ant with
> 'lib' flag. I think there won't be any
> problem now.
>
> As you suggested, I have added my name in uploaders field.
>
>
> On Wed, Aug 19, 2015 at 4:31 PM, Hans-Christoph Steiner <hans@at.or.at>
> wrote:
>
>>
>> Komal Sukhani:
>>> Hi Hans,
>>>
>>> On Tue, Aug 4, 2015 at 6:00 PM, Hans-Christoph Steiner <hans@at.or.at>
>>> wrote:
>>>
>>>>
>>>> Hey Komal,
>>>>
>>>> Looks good overall. You seem to be getting much quicker at packaging
>> :) I
>>>> pushed some commits to fix some minor things. Here are some open
>> issues:
>>>>
>>>> I am glad to know that you are happy with my progress.
>>>
>>>
>>>> * its not building for me, perhaps there is a missing Build-Depends:
>> like
>>>> 'ivy' or something else? Here's the error:
>>>>
>>>> debian/rules build
>>>> dh build
>>>> dh_testdir
>>>> dh_auto_configure
>>>> dh_auto_build
>>>> ant
>>>> Buildfile: /tmp/buildd/cmdreader-1.5/build.xml
>>>>
>>>> config-ivy:
>>>>
>>>> BUILD FAILED
>>>> /tmp/buildd/cmdreader-1.5/build.xml:66: Problem: failed to create task
>> or
>>>> type
>>>> antlib:org.apache.ivy.ant:configure
>>>> Cause: The name is undefined.
>>>> Action: Check the spelling.
>>>> Action: Check that any custom tasks/types have been declared.
>>>> Action: Check that any <presetdef>/<macrodef> declarations have taken
>>>> place.
>>>> No types or tasks have been defined in this namespace yet
>>>>
>>>> This appears to be an antlib declaration.
>>>> Action: Check that the implementing library exists in one of:
>>>> -/usr/share/ant/lib
>>>> -/tmp/buildd/.ant/lib
>>>> -a directory added on the command line with the -lib argument
>>>>
>>>>
>>>> Total time: 0 seconds
>>>> dh_auto_build: ant returned exit code 1
>>>> debian/rules:7: recipe for target 'build' failed
>>>> make: *** [build] Error 2
>>>> dpkg-buildpackage: error: debian/rules build gave error exit status 2
>>>> E: Failed autobuilding of package
>>>>
>>>>
>>>> The build was failing due to missing ivy package. I have added ivy in
>>> build-depends.
>>
>> I tried your latest commits and I still get the same error. Are you able
>> to
>> build this? Does it require packages or package versions that are only in
>> experimental?
>>
>>
>>>> * The whole debian/ directory got included into git after a build was
>> run.
>>>> That means that all of the build products where included as well, they
>>>> shouldn't be. I removed them, and added a debian/.gitignore file so
>> that
>>>> they
>>>> are can't be committed to git.
>>>>
>>>> * add_hamcrest.patch is 0 bytes, either the contents are missing or it
>>>> should
>>>> be removed
>>>>
>>>>
>>> I have made all above changes and have pushed those on Alioth.
>>>
>>>
>>>> * Since this is a java package, I recommend adding it as part of the
>> Java
>>>> team
>>>> (I cc'ed the list) by setting the Maintainer: field. But you are of
>> course
>>>> welcome to keep yourself as the maintainer.
>>>>
>>>> I would love to be a Debian Maintainer. Do I need to do anything for
>>> becoming a Maintainer?
>>
>> You can set yourself as Maintainer: if you want to be the only maintainer
>> for
>> the package. You can add yourself to Uploaders: to mark that you have
>> worked
>> on the package, then set Maintainer: to the pkg-java line used in other
>> pkg-java packages. That marks the package as a "team" package, meaning you
>> are encouraging others to work on it as well.
>>
>>
>
>
>> .hc
>>
>>
>>
>>
>>>> * I pushed a trivial commit to use the canonical, HTTPS URLs for git.
>>>>
>>>> .hc
>>>>
>>>> Komal Sukhani:
>>>>> Hi all,
>>>>>
>>>>> I have packaged cmdreader
>>>>> <https://github.com/rzwitserloot/com.zwitserloot.cmdreader>, which is
>>>>> dependency of lombok-ast, and have
>>>>> uploaded my code to Alioth.
>>>>>
>>>>> Can you please review that package?
>>>>>
>>>>> Now I am working on lombok which is also required by lombok-ast.
>>>>>
>>>>> Komal Sukhani
>>>>>
>>>>
>>>
>>
>
Reply to: