Re: Help with Java package needed

[Markus Koschany <apo@gambaru.de>]

Hi,

On 26.04.2015 07:20, Andreas Tille wrote:
> Hi,
> 
> I intent to package mauve[1] and prepared the package in Git[2].  I was
> able to get rid of several JARs upstream included but it seems now it
> starts to become tricky enough that I need some help.
> 
> The Mauve download contains ext/zeus-jscl.jar.  The source of this is
> available here[3] and I think I was able to create a proper package of
> this in pkg-java Git[4].
> 
> However, if I try to build Mauve which was working before changing the
> location of zaus-jscl.jar in build.xml I get:
> 
> 
> compile:
>     [mkdir] Created dir: /home/andreas/debian-maintain/repack/mauve/mauve-2.4.0+4734/bin
>     [javac] /home/andreas/debian-maintain/repack/mauve/mauve-2.4.0+4734/build.xml:96: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
>     [javac] Compiling 202 source files to /home/andreas/debian-maintain/repack/mauve/mauve-2.4.0+4734/bin
>     [javac] /home/andreas/debian-maintain/repack/mauve/mauve-2.4.0+4734/src/org/gel/mauve/MyConsole.java:17: error: incompatible types
>     [javac]                     console = JConsole.getConsole ();
>     [javac]                                                   ^
>     [javac]   required: JConsole
>     [javac]   found:    JConsolePane
>     [javac] /home/andreas/debian-maintain/repack/mauve/mauve-2.4.0+4734/src/org/gel/mauve/MyConsole.java:22: error: cannot find symbol
>     [javac]                     console.startConsole ();
>     [javac]                            ^

This is an upstream bug because mauve's code is incompatible with the
latest version of zeus-jscl and the code was split into JConsole.java
and JConsolePane.java years ago. I'm attaching a patch which at least
allows mauve to compile but there is still something wrong and the
console window shows only for a second on startup but nothing happens
when I click on the menu entry.

The problem is that in src/org/gel/mauve/MyConsole.java and in
src/org/gel/mauve/gui/MauveFrame.java the console variable is of type
JConsole but it should be JConsolePane. I would file an upstream bug
report for this.

Regards,

Markus

From: Markus Koschany <apo@gambaru.de>
Date: Sun, 26 Apr 2015 15:22:19 +0200
Subject: MyConsole

---
 src/org/gel/mauve/MyConsole.java      | 16 +++++++++-------
 src/org/gel/mauve/gui/MauveFrame.java |  3 +--
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/org/gel/mauve/MyConsole.java b/src/org/gel/mauve/MyConsole.java
index 1781510..d9e7c3a 100644
--- a/src/org/gel/mauve/MyConsole.java
+++ b/src/org/gel/mauve/MyConsole.java
@@ -10,18 +10,20 @@ import java.io.PrintStream;
 public class MyConsole {
 	private static boolean useSwing = false;
 
-	private static JConsole console;
+	private static JConsole console = new JConsole();
 
 	public static void setUseSwing (boolean b) {
 		if (b && !useSwing) {
-			console = JConsole.getConsole ();
 			console.setTitle ("Mauve Console");
 			console.setSize (400, 400);
 			Dimension dim = Toolkit.getDefaultToolkit().getScreenSize();
 			console.setLocation(dim.width-400, 0);
-			console.startConsole ();
+			JConsole.getConsole().startConsole ();
+			if (!console.isVisible()) {
+				console.setVisible(true);
+			}
 		} else if (!b && useSwing) {
-			console.stopConsole ();
+			JConsole.getConsole().stopConsole ();
 			console = null;
 		}
 
@@ -30,13 +32,13 @@ public class MyConsole {
 
 	public static void showConsole () {
 		if (useSwing) {
-			console.showConsole ();
+			JConsole.getConsole().showConsole ();
 		}
 	}
 
 	public static PrintStream err () {
 		if (useSwing) {
-			console.showConsole ();
+			JConsole.getConsole().showConsole ();
 		}
 		return System.err;
 	}
@@ -44,4 +46,4 @@ public class MyConsole {
 	public static PrintStream out () {
 		return System.out;
 	}
-}
\ No newline at end of file
+}
diff --git a/src/org/gel/mauve/gui/MauveFrame.java b/src/org/gel/mauve/gui/MauveFrame.java
index eda9460..e82111e 100644
--- a/src/org/gel/mauve/gui/MauveFrame.java
+++ b/src/org/gel/mauve/gui/MauveFrame.java
@@ -497,8 +497,7 @@ public class MauveFrame extends JFrame implements ActionListener, ModelProgressL
             }
             if (source == jMenuHelpConsole || ae.getActionCommand().equals("Console"))
             {
-            	JConsole console = JConsole.getConsole();
-            	console.showConsole();
+            	JConsole.getConsole().showConsole();
             }
             if (source == jMenuHelpClearCache || ae.getActionCommand().equals("ClearCache"))
             {

Attachment: signature.asc
Description: OpenPGP digital signature