Re: RFS: testng/6.8.7-1 [ITA]

[Eugene Zhukov <jevgeni.zh@gmail.com>]

Thanks, Emmanuel, for this valuable feedback!
On Wed, Sep 11, 2013 at 2:55 PM, Emmanuel Bourg <ebourg@apache.org> wrote:
> Hi Eugene,
>
> Thank you very much for revamping the testng package. That was the only
> package I never managed to build.
>
> I haven't tested the package, but after looking at the source on alioth
> I have a few suggestions:
>
> * You should be able to avoid patching the pom by adding rules in
> debian/maven.rules

I reduced the patch, it only adds one line now <target>1.5<target/>,
since I couldn't find another way to do that.

> * It would be nice to import the upstream source in Git with:
>
>     git-import-orig --verbose --merge --pristine-tar
> testng_6.8.7.orig.tar.gz
>
Why? Full source is available at https://github.com/cbeust/testng

> * The changelog should probably mention that you rewrote the packaging
> using maven-debian-helper and that you dropped all the previous patches.
>
Added

> * You could use canonical URLs for the Vcs-* fields in debian/control to
> avoid a lintian warning.
>
Done

> * I suggest compressing the source tarball with xz, mh_make will do that
> by default in the next release. The syntax for orig-tar.sh is:
>
>     XZ_OPT=--best tar cJf $TAR --exclude '*.jar' --exclude '*.class' $DIR
>
Done

Eugene