Re: Revised RFS: jenkins 1.409.3-1 (new)

[James Page <james.page@ubuntu.com>]

Hi Damien

On 16/12/11 23:46, Damien Raude-Morvan wrote:
> 
> During my review, I've found some binary blobs into source tarball:
> 
> some Windows files (unsure it's okay for main archive)
> war/images/hudson-logo.vsd
> war/src/main/webapp/favicon.ico
> war/src/main/webapp/images/TangoProject-License.url
> 
> Java Keystore ? (maybe generated from something else ?)
> dummy.keystore
> war/src/main/webapp/WEB-INF/update-center-rootCAs/hudson-community
> 
> RTF file (maybe ok for main archive, I'm unsure)
> osx/docs/JenkinsWelcomePanel.rtf
> 
> Zip files (should be dropped)
> test/src/main/resources/*.zip
> test/src/main/resources/plugins/tasks.hpi
> test/src/test/resources/hudson/maven/*.zip
> test/src/test/resources/hudson/tasks/junit/*t.zip
> test/src/test/resources/hudson/tasks/test/*.zip
> test/src/test/resources/hudson/ClassicPluginStrategyTest/*.zip
> test/src/test/resources/hudson/security/*.zip
> test/src/test/resources/hudson/tasks/*.zip
> test/src/test/resources/hudson/model/DependencyGraphTest/*.zip
> test/src/test/resources/hudson/model/JobTest/*.zip
> 
> Sample svn repository (maybe generated from something else ?)
> test/src/main/preset-data/svn-repo/

I'll take a look through these in the next week or so - thanks for
reviewing.

Merry Christmas

James


-- 
James Page
Ubuntu Core Developer