[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libitext5-java (updated package)



Hi Andrew,

On Wed, Apr 13, 2011 at 12:11:06AM +0100, Andrew Ross wrote:
> Dear mentors,
> 
> I am looking for a sponsor for the new version 5.0.6+svn4804-1
> of my package "libitext5-java".

I have checked your package and have some remark to the rules file which
might be based on my vague knowledge about Java packaging.  So if this
is a usual thing to do my concern might be void.  I have seen that you
are Build-Depending from cdbs and you do

  include /usr/share/cdbs/1/rules/buildvars.mk

and the remaining code in debian/rules is pure dh stuff with override_*
targets.  I doubt that this mix of build systems is a good idea and I
wonder whether your changelog entry

  * Moved to using the basic javahelper builder

is connected to a switch to a short debhelper notation and the cdbs
code is just a useless remaining which should rather be removed.

As a further remark I would like to point out that latest Debian stable
release contains debhelper 8 and in the teams I'm working for we now
use debhelper (>=8) and debian/compat contains 8.

In addition Standards-Version should be probably bumped to 3.9.2.

I just to make sure that the way your package is builded is in line with
the Debian Java policy.  If yes, I will sponsor the package as it is.

Kind regards

     Andreas.

-- 
http://fam-tille.de


Reply to: