Re: RFS: jme - high performance scenegraph based graphics java API
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2010-07-03 21:29, Gabriele Giacone wrote:
>
> Hello,
>
> I am looking for a sponsor for my package "jme".
>
> * Package name : jme
> Version : 2.0.1+dfsg-1
> Upstream Author : jME Team <contact@jmonkeyengine.com>
> * URL : http://www.jmonkeyengine.com
> * License : BSD
> Section : java
>
> It builds these binary packages:
> libjme-java - high performance scenegraph based graphics java API
> libjme-java-doc - high performance scenegraph based graphics java API
> (javadoc)
>
> The package is lintian clean.
>
> http://mentors.debian.net/debian/pool/main/j/jme/jme_2.0.1+dfsg-1.dsc
>
> Could anyone take a look and upload it for me?
> DMUA flag will be appreciated too.
>
>
> Thanks for your time,
> Gabriele
Hi
I did not do a full review and I am not a DD, but I do have two comments.
The javadoc is not linking against system javadocs, please link it
against the javadoc of the packages it build against (if these provide a
javadoc). The doc package should also recommend on the packages
providing the javadocs it has linked against.
Also, the binary packages have a lintian warning (v2.4.2)
W: libjme-java: copyright-refers-to-deprecated-bsd-license-file
~Niels
NB: Linking with ant is done by adding <link> tags inside the javadoc.
See http://www.debian.org/doc/manuals/debian-java-faq/ch4.html#s4.4 for
more info.
You may also need to add the jars to the classpath of javadoc so it can
resolve the classes (not sure if it can do that by a link alone or not).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkwv1a0ACgkQVCqoiq1Ylqw70ACfZT1IOV8hBA9rAcatDPr9tISt
oIcAoNXrAf3cL/x5pfTWFQnHMDqKV/KZ
=cO/r
-----END PGP SIGNATURE-----
Reply to: