[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#575850: RFS: libspring-webflow-2.0-java

Hi Miguel,

Here we go for libspring-webflow-2.0-java review :

- debian/patches/02_fix_compilation.diff
You should try to forward your patch upstream (maybe they'll be please to 
deliver you a parser compliant with OGNL version in debian)

- debian/README.Debian-source
Should be renamed to debian/README.source (as per Debian Policy § 4.14)

- debian/control:
  * libspring-js-2.0-java short description seems a bit too generic 
"Javascript abstraction framework". What about "server-side Javascript 
abstraction framework" ?
  * libspring-webflow-2.0-java:
  junit seems removable
  libhibernate3-java is twice + should be Recommends

- projects/spring-js/src/main/resources/META-INF/dojo/
Seems already available inside libjs-dojo-core package
1) you can of course ship it inside original tarball (after all it's DFSG-
2) you should try to use existing JS and don't embedded it in JAR file. I 
don't exactly know how Spring.js can handle this :/ As a general guideline, we 
should try to avoid embedded code copies.
Same apply for META-INF/dijix/ (in libjs-dojo-dijix package)

- notice.txt (install)
There is no need to install this file as we already ship it in source form 
(orig tarball) and copyright notice are provided by "copyright" file in each 
binary package (compliant with Apache License 2.0 §4d)

- readme.txt
Debhelper already take care of changelog.txt, but maybe you should install 
readme.txt too ?

- docs/spring-webflow-reference/
As you already strip Javadoc from source package, you may want to remove all 
this. (As you may know, docbook source is here : projects/spring-webflow-

Embedded code copies is the only blocking issue for me to upload your package. 
Can you provide me some feedback about this ?

Damien Raude-Morvan - http://www.damien-raude-morvan.com/

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply to: