[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Fix for #512149 - checkstyle: provide /usr/bin/checkstyle



Hi Dominik,

On Wed, Mar 25, 2009 at 8:38 AM, Dominik Smatana
<dominik.smatana@gmail.com> wrote:
> I'm sending improved version (using java-wrappers) for review please. (see
> attached diff2.txt)
>
> Any feedback is welcome.

default-jre | java1-runtime | java2-runtime

can be reduced to

default-jre | java2-runtime

and the part

--- debian/dirs	(revision 8114)
+++ debian/dirs	(working copy)
@@ -1,3 +1,4 @@
+usr/bin
 usr/share/java
 usr/share/checkstyle/dtd
 usr/share/checkstyle/xsl

is probably not needed. The patch looks good otherwise.

Cheers,
Torsten


Reply to: