Re: RFS: commons-math
On Sunday 15 March 2009 21:09:33 Matthew Johnson wrote:
> Hi Damien, I'm looking at it now, I've got a couple of points,
Hi Matthew and thanks for taking care.
> firstly, libraries should not depend on runtimes (you depend on
> openjdk-6-jre-headless | java2-runtime-headless), applications using
> them should depend on appropriate runtimes.
Sounds reasonable: I've downgraded openjdk-6-jre-headless to a Suggests.
But now, Lintian complains about "virtual-package-depends-without-real-
package-depends".
May I ignore that ?
By the way, I haven't found any java librairies packages compliant with this
policy [1].
> Secondly, the 'other' licences you list are actually BSD licences, you
> should probably cite them as such and just link to the one in
> /usr/share/common-licences.
BSD license included in /usr/share/common-licenses is "3-clause BSD" whereas
none of the license listed debian/copyright is this particular one.
I would prefer to keep "verbatim copy" of those one (may help FTP-Masters too)
> > This package is build using OpenJDK6 instead of GCJ because OpenJDK6 is
> > really faster doing test-suite (x10 factor).
>
> Is it really faster if you build with openjdk? what about if you build
> with default-jdk and run with gcj? If it is just the JRE which makes a
> difference I think you should build with default-jdk and then just
> document that people should run their apps against it with openjdk.
build time (compile + test-suite) is really faster with OpenJDK6.
Compiled bytecode seems identical between GCJ or OpenJDK javac.
> If it's just the length of time to run the test suite at build time...
> I'm not sure. It's a significant proportion of the build time already,
> does the test suite need to be run on every build?
As Java package are not "autobuilt" by traditionnal Debian buildd network, it
will not take CPU time on autobuilder but only on DD workstation.
I see that as a security guard for invalid upload by others maintainers : you
could (must ?) always have a look a global tests results before uploading.
[1] http://www.debian.org/doc/packaging-manuals/java-policy/x105.html
Cheers,
PS: I've uploaded a new package with downgraded openjdk-6-jre-headless depends
to a Suggests.
--
Damien Raude-Morvan / www.drazzib.com
Reply to: