Re: Bug#489900: Cleanup in .orig.tar.gz or debian/rules?

[Philipp Matthias Hahn <pmhahn@debian.org>]

Hello!

On Thu, Jul 17, 2008 at 01:59:36PM +0300, Kalle Kivimaa wrote:
> Philipp Matthias Hahn <pmhahn@debian.org> writes:
> > 1. Only in the final debian/jspwiki/ tree (but build with the original
> >    .jar files)
> > 2. Each time during the debian/rules run
> > 3. Once in the .orig.tar.gz (the download is only availabe as .zip)
> 
> You can either modify the .orig.tar.gz not to include the jars, or,
> IMO a better choice, modify the building process to use the Debian
> provided jars. I personally prefer keeping the orig.tar.gz as close to
> the original as possible (for JSPWiki all the Debian package does is
> repackage the zip as a tar.gz).
> 
> This process produces a nice and clean build process with the existing
> debian/rules file.

$ du -skh lib tests/lib .
3,9M    lib
7,5M    tests/lib
21M     .

Yes, but more than halve the source consists of files Debian shouldn't
ship, because the source for those 11 MB .jar-files isn't included with
the JSPWiki source .zip file.

> > the files in lib/ are. I'm not aware of any other Debian package
> > shipping them also, so is it okay to include them in jspwiki only or do
> > I need to split them into their own packages?
> 
> If you are planning on doing a NMU then you need to split those out
> and package them separately. All Debian packages must contain
> buildable source for all code, and considering the JSPWiki package
> doesn't contain source for the extra libraries, it is far better to
> package them separately. If those libraries really aren't included in
> Debian, 2.6.3 won't be packaged very soon by me.

Sorry, but 2.5.139 already violates this rule. The following .jar-files
marked with * don't have a source in Debian (as far as I know), + is an
older version of the one in Debian.

$ dpkg -c jspwiki_2.5.139-1.1_all.deb | awk '/\.jar/ { print $6; }'
* ./usr/share/jspwiki/WEB-INF/lib/freshcookies-security-0.54.jar
  ./usr/share/jspwiki/WEB-INF/lib/oro.jar
* ./usr/share/jspwiki/WEB-INF/lib/jug-lgpl-2.0.0.jar
* ./usr/share/jspwiki/WEB-INF/lib/mail.jar
  ./usr/share/jspwiki/WEB-INF/lib/nekohtml.jar
* ./usr/share/jspwiki/WEB-INF/lib/multipartrequest.jar
  ./usr/share/jspwiki/WEB-INF/lib/log4j-1.2.14.jar
  ./usr/share/jspwiki/WEB-INF/lib/lucene-highlighter.jar
* ./usr/share/jspwiki/WEB-INF/lib/ecs.jar
* ./usr/share/jspwiki/WEB-INF/lib/akismet-java-1.02.jar
* ./usr/share/jspwiki/WEB-INF/lib/jsonrpc-1.0.jar
* ./usr/share/jspwiki/WEB-INF/lib/jakarta-tablibs-standard-1.1.2.jar
  ./usr/share/jspwiki/WEB-INF/lib/jdom.jar
  ./usr/share/jspwiki/WEB-INF/lib/commons-httpclient-3.0.1.jar
+ ./usr/share/jspwiki/WEB-INF/lib/xmlrpc.jar
  ./usr/share/jspwiki/WEB-INF/lib/lucene.jar
  ./usr/share/jspwiki/WEB-INF/lib/jaxen.jar
  ./usr/share/jspwiki/WEB-INF/lib/commons-codec-1.3.jar
  ./usr/share/jspwiki/WEB-INF/lib/activation.jar
  ./usr/share/jspwiki/WEB-INF/lib/JSPWiki.jar
* ./usr/share/jspwiki/WEB-INF/lib/jrcs-diff.jar
  ./usr/share/jspwiki/WEB-INF/lib/oscache.jar
  ./usr/share/jspwiki/WEB-INF/lib/commons-lang-2.0.jar
* ./usr/share/jspwiki/WEB-INF/lib/sandler.jar
* ./usr/share/jspwiki/WEB-INF/lib/jakarta-taglibs-jstl-1.1.2.jar
  ./usr/share/jspwiki/applets/wikiwizard.jar

BYtE
Philipp
-- 
Philipp Matthias Hahn <pmhahn@debian.org>
 GPG/PGP: 9A540E39 @ keyrings.debian.org