[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: openjdk-6_6b08-1_i386.changes REJECTED

Thomas Viehmann schrieb:
> Hi,
> the java.net list is subscriber only and after some chat it appears that
> most of the problems are indeed local to Debian, so I dropped them from
> the CC.

Didn't notice the subscriber-only thing. I added the list for this reply for
some input on the generated files.

> Matthias Klose wrote:
>>>>> - The debian/copyright file seems to miss a lot of
>>>>>   copyright notices (e.g. of Red Hat, Maxwell, ASF,
>>>>>   I stopped after finding four). This is the main
>>>>>   reject reason.
> Of course, the ASF copyright is included in debian/copyright, shame on me.
> Thanks Matthias for pointing that out on IRC.

- About Red Hat; these files were submitted by a RedHat developer, who
  is listed in debian/copyright, but Red Hat itself was not listed. Added.
- Same for the Maxwell name, which came in with a patch to the IcedTea
- Added two other names, and two organizations.
- I am not aware of missing license in the debian/copyright

On IRC Thomas and I agreed on not including the names for copyrights in
GNU files like aclocal.m4, install-sh, and other similiar files. It would be
nice if a common practice could be documented, how such files should be handled.

This is what I committed:
$ bzr diff
=== modified file 'copyright'
--- copyright	2008-04-01 07:24:19 +0000
+++ copyright	2008-04-19 13:43:26 +0000
@@ -57,9 +57,18 @@
     Portions Copyright © 2007 Joshua Sumali <jsumali@redhat.com>
     Portions Copyright © 2007 Christian Thalinger <twisti@complang.tuwien.ac.at>
     Portions Copyright © 2007 Mark Wielaard <mark@klomp.org>
+    Portions Copyright © 2007, 2008 Red Hat, Inc.
+    Portions Copyright © 2001-2003 Jon A. Maxwell (JAM)
+    Portions Copyright © 1992, 1995-2007 Sun Microsystems, Inc.
+    Portions Copyright © 2007 Matthew Flaschen
+    Portions Copyright © 2000-2002 Marc De Scheemaecker
+    Portions Copyright © 1991-1998 Thomas G. Lane
+    Portions Copyright © 2007 Free Software Foundation, Inc.
-    Copyright © 2007 Sun Microsystems, Inc.
+    Copyright © 1996-2007 Sun Microsystems, Inc.
+    For third party copyrights see below (copies from the third party readme).
+    Portions Copyright © 1993-1999 IBM Corp.

 Java Access Bridge:
     Portions Copyright © 2002-2007 Bill Haneman <bill.haneman@sun.com>
@@ -72,7 +81,7 @@
     Portions Copyright © 2002-2007 Darren Kenny <darren.kenny@sun.com>

-    Copyright © 2007 Canonical Ltd.
+    Copyright © 2007, 2008 Canonical Ltd.


>>>>> - There are some files in the generated subdir that
>>>>>   I'm not sure I found the source of. Could you
>>>>>   clarify this a bit for me?
> Matthias pointed to the source for the IDL-generated files on IRC,
> resolving quite a bit of the concerns. Thanks.
> Some stuff I am currently not sure about how to find the source (all in
> generated/)
> - java/nio,

see jdk/make/java/nio

> - the language specific stuff, (files ending in _??.java, some in
>   */{lang,util}),

see jdk/make/java/java

> - the things generated by mc.scm (com/sun/corba/se/impl/),

not sure what you exactly mean.

> - some stuff in */management/ (some with "generated by rmic" notice).

see jdk/src/share/classes/sun/management/resources.

> The source for all of these probably is well known to the experts, so
> the above is as much for my own reference as it for you knowing what I
> am presently not sure about in case you want to help me find things.

Maybe a build log can help finding the locations of the build bits and the
source files. Please see:


Reply to: