Re: Package review (java-snmp).
On Tue, Dec 28, 2004 at 12:18:44AM +0100, Arnaud Vandyck wrote:
> > I have prepared [1] a Debian-package of the Java SNMP Package [2][3],
> > and it would be great if someone with more knowledge to java and
> > packaging Java-libraries for Debian reviewed it before I ask someone
> > to sponsor an upload.
>
> Michael 'Magic Man-Di' Koch told me you did move the package. I review
> it and it was very good. There is only one thing: you use
> `/usr/bin/javac' and `jar' in debian/rules. You should not relay on
> symlinks to build the package. So I did set a variable to find the
> location of the two executables. Maybe it's not the better way to do
> it. You could define `JAVAC' and `JAR' variables.
>
> Here is how I changed the debian/rules. I signed it and uploaded it.
>
> If you don't like the way I did modify the package (I should not modify
> it but tell you how to modify it, then re-review the new package
> etc). You can make a new package and I'll sponsor it one more time.
[snip]
> I hope you agree with the changes. If you need a sponsor for other java
> related packages, feel free to contact me in private. If I can't do the
> job, I'll try to told it to you as soon as possible so you'll have to
> ask again on d-java or d-mentors.
I am perfectly ok with the changes and the upload. I have since the
summer worked with a rather large package which as software pieces
written in Java, Perl, PHP and Python, and I hope
> Cheers and many thanks for your job.
No, thank you! :)
- Werner
Reply to: