[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: request feedback on JBOSS debs



On Mon, 2003-01-20 at 05:00, Greg Wilkins wrote:
> 
> Your jboss debs for 3.0.2-2 deployed without problems on my
> debian sid system.  Good work!

Great!  thanks.

>   + Does it really need to depend on your jdk1.4 package?
>     Jboss can run on 1.3 and most debian users will have already
>     installed jdk - having an extra 40MB download is a bit of a
>     hurdle for most.

I don't think I explicitly depend on 1.4.  Nor do I depend on my j2sdk
package.  Across the different packages, I only depend on
java-virtual-machine, java2-runtime and java2-compiler.  I suppose that
if your system didn't have packages providing them, apt-get would want
to install my jdk.

>   + The setting of JAVA_HOME should be done by an auto search and/or
>     a debconf dialog.

That was planned for a later revision, provided it is needed (see
previous JAVA_HOME thread).

>   + The default webcontainer for jboss is Jetty, but you don't appear
>     to allow just the default deployment - as it depends on tomcat.

I don't know what you mean by the default deployment.  jboss-tomcat is
it's own, optional package.  Note that jboss-server-all and
jboss-server-default depend on jboss-tomcat.  The deployment that my
packages install is straight out of the binary release from sourceforge.

<lightbulb>  Are you saying that the non-tomcat binary releases are
configured for jetty? </lightbulb>  If so, I was not aware of that.  I
figured they were jboss without any web containers.  I'll need to look
into this.

>     Tomcat is an optional extra and really should be presented that
>     way.   Alternately you should have a jboss-jetty deb that is
>     the default webcontainer for jboss, which may be replaced by
>     jboss-tomcat.

At some point I would like to clean up the way this is built.  I
certainly want to have jetty packages and be flexible enough to
add/remove tomcat and jetty.

>   + I see you have taken the approach of just including all the jars
>     that jboss uses in the lib directories as if you had installed
>     jboss normally.  I can see the logic of this (simplicity) but
>     in reality it really should use the jars from /usr/share/java
>     is that your eventual intent?

I figured this was a reasonable first revision.  We needed to get *some*
jboss packages on our systems.  I chose to make the packages pretty much
a stock binary distro from sourceforge just so I have *something* to
start with.  As you note, this is for simplicity.  I plan for future
revisions to start symlinking to jars within /usr/share/java.

These things will grow and improve over time.  Some of your comments are
leading me toward a re-organization of the jboss install directories
which I touched on in a previous email.

Thanks for the feedback.

-joe
-- 
     Innovation Software Group, LLC - http://www.innovationsw.com/
                Business Automation Specialists
                 UNIX, Linux and Java Training



Reply to: