Re: Bug in IMP Debian package
On Thu, Apr 03, 2003 at 01:30:57PM +0200, Tomàs Núñez Lirola wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
Hello
The imp debian package is depricated. You should really use the
imp3 packages from sarge. The support for imp2 (imp package) stopped
upstream over a year ago.
Regards,
// Ola (The imp package maintainer, but not imp3 :)
> Hi
> I think I've found a bug in IMP Debian package.
> When I saved "Full Name" on preferences, IMP added a "<" to the end of the
> full name. Then, when I sent a message, the "From:" appeared something like
> that:
> myname@my.host.com, UNEXPECTED_DATA_AFTER_ADDRESS@.SYNTAX-ERROR
>
> I looked at the database and I found this "<" in the "Full Name" field. I
> looked where this string was added to the database and I found this function
> ___________________________________________________________
> if (isset($fullname) && ($fullname != $old_fullname)) {
> // filter for existing quotes
> if (substr($fullname, 0, 1) == '"' && substr($fullname, -1) == '"') {
> $fullname = substr($fullname, 1, -1);
> }
> // filter for illegal characters
> $quoted = imap_rfc822_write_address('', '', $fullname);
> $quoted = substr($quoted, 0, strlen($quoted)-4);
> if (!(imp_set_fullname(addslashes($quoted), $imp->user, $imp->server))) {
> $errormsg .= $lang->fullname_error;
> $updated = false;
> }
> }
> _______________________________________________________________
>
> I don't know a lot about PHP, so I don't fully understand this function, but I
> changed the 8th line
> $quoted = substr($quoted, 0, strlen($quoted)-4);
> changing the -4 for a -5
> $quoted = substr($quoted, 0, strlen($quoted)-5);
>
> and now it works perfectly (I think).
>
> My questions are:
> Anyone faced this problem before? (In other words, is this a real bug or it's
> only on my IMP?)
> Should I inform IMP Debian package mantainer? Or IMP coders?
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.1 (GNU/Linux)
>
> iD8DBQE+jBt0GOU6HQZ81TcRAsXOAJ4t9aTOveJmC509qpv339w27jTT4gCeKu+p
> monXKMtceZhkkLXtuJU2QnE=
> =N8sd
> -----END PGP SIGNATURE-----
>
>
> --
> To UNSUBSCRIBE, email to debian-isp-request@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
>
--
--------------------- Ola Lundqvist ---------------------------
/ opal@debian.org Annebergsslingan 37 \
| opal@lysator.liu.se 654 65 KARLSTAD |
| +46 (0)54-10 14 30 +46 (0)70-332 1551 |
| http://www.opal.dhs.org UIN/icq: 4912500 |
\ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
---------------------------------------------------------------
Reply to: