Bug#1085340: fcitx: calls dbus_get_local_machine_id() which has bad error-handling

[Simon McVittie <smcv@debian.org>]

Source: fcitx
Version: 1:4.2.9.9-2
Severity: normal
Tags: upstream

Several files in fcitx contain calls to dbus_get_local_machine_id(),
which has no good mechanism for reporting an error, and therefore will
spam warnings to standard error (and possibly crash) if the D-Bus machine
ID has not been set up correctly. This function should be considered
deprecated.

Please prefer to use dbus_try_get_local_machine_id(), which takes a
DBusError parameter (same calling convention as e.g. dbus_validate_path())
and therefore can be used to report errors in whatever way is considered
to be most appropriate by the caller. This has been available in upstream
stable releases since dbus 1.12.0 (2017).

Thanks,
    smcv