[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1018871: ibus-tests:armel: depends on gnome-shell:armel which is likely to be removed



Package: ibus-tests
Version: 1.5.27-1
Severity: important
Tags: patch
Control: block 1018076 by -1

ibus-tests depends on gnome-shell, which it uses to run the ibus test
suite.

As a result in changes to mozjs, it looks likely that we will have to
remove gjs from the armel architecture, which means also removing
gnome-shell:armel (see #1018076). This will make the ibus-tests:armel
package uninstallable.

The obvious solution is to remove ibus-tests:armel as well, but because
ibus does not have a direct or indirect build-dependency on gjs,
ibus-tests:armel would just come back (and be uninstallable) next time
ibus was rebuilt.

I think there are two choices for how to deal with this:

1. Only build and run ibus-tests on architectures with a working gjs,
   but continue to build the rest of the ibus package on architectures
   where gjs is unavailable
2. Add a direct or indirect build-dependency on gjs so that none of the
   ibus packages are built on architectures where gjs is unavailable

The attached patch implements the first option. It is untested, but I
hope it does the right thing.

I think the second option would be appropriate if ibus is not intended to
be used at all on non-GNOME desktops, but looking at its bug list, it
seems to be at least partially usable in non-GNOME desktops like XFCE.

    smcv
>From 74851cd092bc19bed3c1c3e8dc9864325237b033 Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@debian.org>
Date: Thu, 1 Sep 2022 08:59:57 +0100
Subject: [PATCH] Only build and run ibus-tests on architectures with working
 mozjs102

When gjs moves from mozjs91 to mozjs102, it is likely to lose support
for the armel architecture, making gnome-shell:armel and therefore
ibus-tests:armel uninstallable (see #1018076). The current plan is to
remove the uninstallable packages from armel, but to make that work,
ibus needs to stop building the package so it won't come back.

The architecture list used here matches the architectures on which
gjs/experimental was successfully built: all release architectures
except armel, plus the non-release architecture riscv64.
---
 debian/control       | 2 +-
 debian/tests/control | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 2ac9198e..7ce39223 100644
--- a/debian/control
+++ b/debian/control
@@ -96,7 +96,7 @@ Description: Intelligent Input Bus - data files
 
 Package: ibus-tests
 Build-Profiles: <!noinsttest>
-Architecture: any
+Architecture: amd64 arm64 armhf i386 mips64el mipsel ppc64el s390x riscv64
 Multi-Arch: foreign
 Depends: ${misc:Depends},
          ${shlibs:Depends},
diff --git a/debian/tests/control b/debian/tests/control
index 8016abf6..2a0a0a19 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -3,4 +3,5 @@
 # testbed.
 Tests: installed-tests
 Depends: ibus-tests
+Architecture: amd64 arm64 armhf i386 mips64el mipsel ppc64el s390x riscv64
 Restrictions: allow-stderr, needs-root, breaks-testbed
-- 
2.37.2


Reply to: