[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1001868: marked as done (fcitx: reproducible-builds: BuildId differences triggered by RPATH)

Your message dated Sat, 28 May 2022 17:34:03 +0000
with message-id <E1nv0KB-000DSK-5q@fasolo.debian.org>
and subject line Bug#1001868: fixed in fcitx 1:4.2.9.8-8
has caused the Debian Bug report #1001868,
regarding fcitx: reproducible-builds: BuildId differences triggered by RPATH
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1001868: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001868
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: fcitx
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The RPATH contains the build path resulting in different buildid:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/fcitx.html

The attached patch to debian/rules passes
-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via a dh_auto_configure override,
which should use a relative path for RPATH.

With this patch applied, fcitx should build reproducibly on
tests.reproducible-builds.org!

Thanks for maintaining fcitx!

live well,
  vagrant

From b7515c1dc81e62af1c27d2f220dd314d441d25cc Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Fri, 17 Dec 2021 23:38:36 +0000
Subject: [PATCH] debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
 dh_auto_configure override.

This avoids embedding the full path in RPATH, which triggers BuildId
differences.

https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
---
 debian/rules | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 3bb24a7..0a4866c 100755
--- a/debian/rules
+++ b/debian/rules
@@ -36,7 +36,8 @@ override_dh_auto_configure: gen_control
 	    -DENABLE_ICU=ON \
 	    -DENABLE_BACKTRACE=ON \
 	    -DENABLE_XDGAUTOSTART=ON \
-	    -DENABLE_GETTEXT=ON
+	    -DENABLE_GETTEXT=ON \
+	    -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON
 
 override_dh_makeshlibs:
 	dh_makeshlibs -plibfcitx-core0
-- 
2.34.1

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Source: fcitx
Source-Version: 1:4.2.9.8-8
Done: Boyuan Yang <byang@debian.org>

We believe that the bug you reported is fixed in the latest version of
fcitx, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1001868@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Boyuan Yang <byang@debian.org> (supplier of updated fcitx package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 28 May 2022 13:09:07 -0400
Source: fcitx
Architecture: source
Version: 1:4.2.9.8-8
Distribution: unstable
Urgency: medium
Maintainer: Debian Input Method Team <debian-input-method@lists.debian.org>
Changed-By: Boyuan Yang <byang@debian.org>
Closes: 1001868
Changes:
 fcitx (1:4.2.9.8-8) unstable; urgency=medium
 .
   * Team upload.
   * debian/rules: Pass -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON via
   dh_auto_configure override for reproducibility. (Closes: #1001868)
Checksums-Sha1:
 dd1296ad1a5f6123503535fef83af74e167f669d 4340 fcitx_4.2.9.8-8.dsc
 6811c6281be37cba8fc327c2729d58776111627d 8737888 fcitx_4.2.9.8.orig.tar.xz
 004951abd15b2cc2f23758d8f13339a827745b20 26716 fcitx_4.2.9.8-8.debian.tar.xz
 9d27cd6ba06081158ed4b981b9f31ad4f45b6c20 30479 fcitx_4.2.9.8-8_amd64.buildinfo
Checksums-Sha256:
 2d26292f0601cb65bf5346843b523c9a1ec4e3c941da1a9faa5029678fea9e95 4340 fcitx_4.2.9.8-8.dsc
 bc3515cba0561546fe02dae81391d4a03e0e79a2d668aa794cd3a377284033c6 8737888 fcitx_4.2.9.8.orig.tar.xz
 e1f597a3285cc1b2f0fb8ab20341325d15d412699090aaf81ed3d3a992b08223 26716 fcitx_4.2.9.8-8.debian.tar.xz
 817459ca8e0d5628d5566ce38533c415d1ccf2a5352c4ddc6cce40bce40173f9 30479 fcitx_4.2.9.8-8_amd64.buildinfo
Files:
 ae9979d234105b1b3812633ddbc990bf 4340 utils optional fcitx_4.2.9.8-8.dsc
 fbd1d76ce81353f003dffb73053b4803 8737888 utils optional fcitx_4.2.9.8.orig.tar.xz
 573527297f426081b3aa4978344b5495 26716 utils optional fcitx_4.2.9.8-8.debian.tar.xz
 7a6c2433bd0c6079698e8e545863c70f 30479 utils optional fcitx_4.2.9.8-8_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEfncpR22H1vEdkazLwpPntGGCWs4FAmKSV/4ACgkQwpPntGGC
Ws6y7xAAgY/jsvMo+H4kcJU5KO2JX7AM/HJcmx1tqylT+G3jlbiKLWqeKzHcB5/W
lj+qJuy7Ld/PphCcMtXomAT9FmFKvh74zI0S/93t+3Af4i22gGt9pTyJcLT0/euH
khh3lxTSnkRJQYyd3j5WrrFvG0pXzcTXtPEN9vPfmqKRjSsgQ7QfXsCT/QmX0GjM
wX1anywuzNjc8xIsZsbRoqF6JGTBUOjKE82+zFgeXCorHJ943kQ1t7H5HQWIDr7m
K/K+xkIeUNac2pNx/Us2hRuAQys0o/7S382NRtanyFz88Q0t7GumrhhmeHKEzuwn
pquHPjrKXQVelS1UnTSZg+TN05edLIjY2ccS/a0Wbvl2sh+4pBzlKas/W391hLBX
17Tt8AdGnBpiWcOFQNHvkLRRGZcqg7nHnfZcKEy0+FfxPdWg+QI4vxitoG2KYJ9W
vknHBskpJGGYgaO7gT0av8Jq7xVqJ+HsPN2XbGCGGPykPckmzn7GuwBovengdx80
QcnhpTKmje6Hzkm7eNgs+Nz34ylqMJR0fBWn/Gq+/j9o9HfkUiOs42V4S09gMnra
XyOgx+WyLbPYg7T0rqCn7hLdp4hBihOg20PKepqxkZs6QPm8YSGdE/qwGUq7vwHz
z3czL3t5SQiSgyxLEmRYwIgrDnGVVPHSsSIwZztObhIMuJq3oK0=
=jc/3
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: