[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-ime-devel] Bug#645729: Bug#645729: checking for ibus support in gtk2 and gtk3 separately



Hi,

On Mon, Oct 17, 2011 at 11:46:54PM -0700, Steve Langasek wrote:
> Package: ibus
> Version: 1.4.0-1
> Severity: normal
> Tags: patch
> User: ubuntu-devel at lists.ubuntu.com
> Usertags: origin-ubuntu precise ubuntu-patch
> 
> Hello,
> 
> The Ubuntu package of ibus includes a patch to debian/xinput/ibus to check
> for ibus support in each version of gtk separately.  The reason for this is
> given at <https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/823202>.
> Basically, if both ibus-gtk and ibus-gtk3 are installed (as should be the
> case for a while, since the transition to gtk3 is ongoing), the file check
> will fail because the glob expands to multiple files.

Thanks for fix of multi-arch for im-switch.  I am about to fix in im-config
package side.  (Since im-switch is not used for ibus now, I do not know use of
this as is but if we make changes as below, it is useful for wheezy.)

> If only one of ibus-gtk or ibus-gtk3 is installed, I don't know what the
> desired behavior would be here, but I think we should fall back to xim in
> that case because it's safer.

This is very deep question.  

But practically thinking, control file needs update to fix this problem:

Now we have:
Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends},
 python-ibus (= ${source:Version}), python-xdg, librsvg2-common, python-notify, im-config
Recommends: ibus-gtk | ibus-qt4 | ibus-clutter
Conflicts: ibus-anthy (<< 1.2),
 ibus-table (<< 1.2),
 ibus-pinyin (<< 1.2.99),
 ibus-m17n (<< 1.2.99),
 ibus-hangul (<< 1.2.99),
 ibus-chewing (<< 1.2.99)

I think correct thing to do is:
Depends: ${shlibs:Depends}, ${misc:Depends}, ${python:Depends},
 python-ibus (= ${source:Version}), python-xdg, librsvg2-common, python-notify
Recommends: ibus-gtk3, ibus-gtk, ibus-qt4, ibus-clutter, im-config
Conflicts: ibus-anthy (<< 1.2),
 ibus-table (<< 1.2),
 ibus-pinyin (<< 1.2.99),
 ibus-m17n (<< 1.2.99),
 ibus-hangul (<< 1.2.99),
 ibus-chewing (<< 1.2.99)

So they all get installed as defualt, if admin choses not to do so, he should
deal with it.  im-config has option to force using xim as default too.

If we can move all im packages to use im-config as recommend, then we can drop
overcomplicated im-switch script for most people.  If someone imsist after
wheezy, he can manually install it. (Or chose any other local method.  I do not
think im-config should be Depends as its upstream.)

As for im-switch script, we release package to check both gtk3 only if GNOME is
moving almost all to gtk3.  Then remove this script altogether after wheezy.

Regards,

Osamu





Reply to: