Re: [PATCH v2 0/3] Bli: fix hidden module dependency
On Tue, Nov 21, 2023 at 04:00:35PM +0100, Daniel Kiper wrote:
> On Thu, Nov 16, 2023 at 02:50:17PM +0100, Daniel Kiper wrote:
> > Adding a few folks who can be interested in this patch set...
> >
> > On Wed, Nov 15, 2023 at 09:07:59PM +0100, Oliver Steffen wrote:
> > > The bli module has a hidden/implicit dependency on the part_gpt module.
> > > The part_gpt module has to be loaded before the bli module.
> > > This dependency is not picked up automatically by the build system
> > > because the bli module does not use any function of part_gpt. It just
> > > expects Grub to be able to parse GPT formatted disks.
> >
> > Please be more consistent and use GRUB instead of Grub or other forms
> > everywhere.
> >
> > Additionally, we are missing extra_deps.lst exception entry in .gitignore.
> > Could you add it?
> >
> > > This series introduces a mechanism that allows specifying module
> > > dependencies explicitly in a new file called extra_deps.lst.
> > >
> > > An explicit dependency is then added for the bli module on the part_gpt
> > > module and the documentation is improved.
> > >
> > > Changes since v1 [1]:
> > > - rename explicit_dependencies.lst -> extra_deps.lst
> > > - explain what bli does/why it needs part_gpt in the commit message
> > > - and in the module documentation as well.
> > >
> > > [1] https://mail.gnu.org/archive/html/grub-devel/2023-11/msg00077.html
> > >
> > > Oliver Steffen (3):
> > > Allow explicit module dependencies
> > > bli: Add explicit dependency on the part_gpt module
> > > bli: Improve documentation
> >
> > Otherwise patch set LGTM...
> >
> > A few days ago Vladimir pushed fixes for GUID types. I hope together
> > with this patch set all known x86_64, aarch64 and IA-64 EFI issues are
> > fixed. So, folks, in particular Tobias, please test the latest GRUB
> > upstream master branch with these patches on top. Even if they require
> > some minor polishing. When everything is OK we can assume at least this
> > release roadblock has been lifted...
>
> Tobias and other folks, ping? I would really love to hear something from
> you soon...
Ping? If I do not hear anything from you guys soon I will assume
everything works as expected, merge these patches and cut the release
by the end of next week or so... We are long behind the schedule...
Daniel
Reply to: