[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Hint for a port of a package



On Sat, Nov 02, 2002 at 03:46:24PM -0800, Randolph Chung wrote:
> > -  syslog(LOG_WARNING, "cmd_q(): malloc(%d) returned NULL",
> > sizeof(struct ordq_item_t));
> > +  syslog(LOG_WARNING, "cmd_q(): malloc(%d) returned NULL", (int)
> > sizeof(struct ordq_item_t));
> 
> this is ok, but better would be:
> syslog(LOG_WARNING, "cmd_q(): malloc(%ld) returned NULL", sizeof(struct ordq_item_t));

ANSI specifies %z for size_t so better would be:

syslog(LOG_WARNING, "cmd_q(): malloc(%z) returned NULL", sizeof(struct ordq_item_t));

Agreed on the list_find function.

-- 
Revolutions do not require corporate support.



Reply to: