[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: cppi: i18n.debian.org: source does not specify a priority



Thanks to textshell on IRC who found the relevant code, which allowed me
to create a patch to solve the problem below:

https://salsa.debian.org/l10n-team/dl10n/-/merge_requests/11

What is the best way to submit a proper bug report and patch?  For some
reason it seems the 'dl10n' package is not in Debian?!  Where should bug
reports go?

https://tracker.debian.org/pkg/dl10n

I'm attaching the patch for easier email-based review.

/Simon

Simon Josefsson <simon@josefsson.org> writes:

> Hi!
>
> I dropped the 'Priority: optional' field from the debian/control Source
> stanza for 'cppi' in the last upload, and now i18n.debian.org says I
> have an error in my *.po files?!
>
> https://i18n.debian.org/l10n-pkg-status/c/cppi.html
>
>  The following errors were found in cppi 's PO files:
>
>  source does not specify a priority
>       
>
> Any ideas?
>
> /Simon
>
From 28670fc27f2f268dd47c89a76559f3778c1d9daf Mon Sep 17 00:00:00 2001
From: Simon Josefsson <simon@josefsson.org>
Date: Sat, 3 Jan 2026 11:44:09 +0100
Subject: [PATCH] Let missing Priority field mean optional

Debian Policy 4.7.3 was updated to allow Priority fields to be optional

https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities

Some improved wording are discussed but effect remains the same

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1124443
---
 dl10n-check | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/dl10n-check b/dl10n-check
index 1bc4174..b0cbe0f 100755
--- a/dl10n-check
+++ b/dl10n-check
@@ -472,6 +472,8 @@ sub parse_tarball {
         }
         if (exists $source->{Priority}) {
             $priority = $source->{Priority};
+        } else {
+            $priority = "optional";
         }
         if ($section eq "") {
                 $data->add_errors($pkg,"source does not specify a section\n");
@@ -487,10 +489,7 @@ sub parse_tarball {
                         $section  = "?";
                 }
         }
-        if ($priority eq "") {
-                $data->add_errors($pkg,"source does not specify a priority\n");
-                $priority  = "?";
-        } elsif (!exists($priorities{$priority})) {
+        if (!exists($priorities{$priority})) {
                 $data->add_errors($pkg,"'$priority' is not a valid priority\n");
                 $priority = "?";
         }
-- 
2.52.0

Attachment: signature.asc
Description: PGP signature


Reply to: