[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#909080: marked as done (dl10n-spider stops parsing mails when there is a month without mails)

Your message dated Thu, 18 Oct 2018 14:44:52 +0200
with message-id <ead3306e-96f4-2dac-a4ef-4f138547a9d0@debian.org>
and subject line Bug #909080: [SOLVED] dl10n-spider stops parsing mails when there is a month without mails
has caused the Debian Bug report #909080,
regarding dl10n-spider stops parsing mails when there is a month without mails
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
909080: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=909080
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: debian-i18n
Severity: normal

Dear all
It seems that the script that parses the l10n-language mailing list archives and creates the databases in l10n.debian.org/coordination/00data/status.XX stops (without errors) when there is a month in which no mails were sent to the list (thinking that we arrived the current month/year). 

See for example:

https://l10n.debian.org/coordination/turkish/tr.by_date.html

I believe this pages are generated using the data here:

https://l10n.debian.org/coordination/00data/

the status.tr file there stops parsing at year 2016 month 6:

Package:
Date: 2018-09-18
Year: 2016
Month: 6
Message: 0
Page: 1

This behavior can be easily reproduced in this way:

sudo apt install dl10n
git clone https://salsa.debian.org/l10n-team/dl10n.git
cd dl10n/
mkdir data
touch data/status.tr
./dl10n-spider --year 2016 --month 01 --message 0 tr

(it begins to parse and stops in 2016/06)
./dl10n-spider --year 2016 --month 07 --message 0 tr

(it continues to parse and stops in 2017/05)

./dl10n-spider --year 2017 --month 07 --message 0 tr
(it continues to parse and stops in 2017/11, etc.)
If you look at https://lists.debian.org/debian-l10n-turkish/ the script stops when it arrives a year/month without mails, but can continue if we provide a starting point after that empty month.
I've had a look at the code and I think that we should modify the code of the file https://salsa.debian.org/l10n-team/dl10n/blob/master/lib/Debian/L10n/Spider.pm , sub spider($$$$$@) (Line 173 on). I'm afraid I cannot provide a patch, the code is difficult for me to understand and I'm not sure what should I change and how. 

I hope somebody else can look at this...

Thanks

--
Laura Arjona Reina
https://wiki.debian.org/LauraArjona

--- End Message ---
--- Begin Message --- 
Hello all
This bug is solved now, thanks Guillem Jover who provided the patch:

https://salsa.debian.org/l10n-team/dl10n/merge_requests/3/diffs

(Below you can find the list of commits).

Thanks
--
Laura Arjona Reina
https://wiki.debian.org/LauraArjona

commit fe81c6606a464428ea7f013de9b25ed8858ef9ad
Merge: a3c1e34 b3ddbea
Author: Laura Arjona Reina <larjona@debian.org>
Date:   Thu Oct 18 09:38:46 2018 +0000

    Merge branch 'pu/spider-fix' into 'master'

    Fixes for the spider logic

    See merge request l10n-team/dl10n!3

commit b3ddbea26d2d2639ca01b62fba6958b800de867b
Author: Guillem Jover <guillem@debian.org>
Date:   Thu Oct 18 11:00:50 2018 +0200

    Debian::L10n::Spider: Use the current year as a loop terminator

    We should not be using whether there are messages for a given month
    as the terminator condition when scanning the archive, as nothing
    guarantees some teams have had activity on every year.

    Check against the current year instead.

    Closes: #909080

commit fb24ae287edef519372fb4d6906aae7e4641e0a1
Author: Guillem Jover <guillem@debian.org>
Date:   Thu Oct 18 10:58:12 2018 +0200

    Debian::L10n::Spider: Try to use /etc/ssl/ca-debian only if available

    This file is commonly only found in Debian servers. Using it
    unconditionally makes all HTTP requests fail when it is not available.

commit 62e19b1598511ddcc99458c697fd6977f476f8c5
Author: Guillem Jover <guillem@debian.org>
Date:   Thu Oct 18 10:59:55 2018 +0200

    Debian::L10n::Utils: Escape left-hand curly brace in regex

    Warned-by: perl

--- End Message ---
Reply to: