[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Hurd NFS translator



Hello,

Michael Kelly, le jeu. 10 juil. 2025 22:29:35 +0100, a ecrit:
>        *(p++) = ntohl (read_size);
>        err = conduct_rpc (&rpcbuf, &p);
> -      if (!err)
> +      if (err)

Better keep it factorized.

>  	{
> -	  err = nfs_error_trans (ntohl (*p));
> -	  p++;
> +	  free (rpcbuf);
> +	  free (buf);
> +	  return err;
>  	}
> +
> +      err = nfs_error_trans (ntohl (*p));
> +      p++;
> +
> +      if (protocol_version == 3)
> +	/* 'post_op_attr' is present for any value of 'err' */
> +	p = process_returned_stat (dir, p, 1);

But then it is no use doing it in case of error since we just return in
that case.

Samuel


Reply to: