[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1107992: marked as done (drop Rules-Requires-Root)

Your message dated Mon, 23 Jun 2025 01:25:04 +0000
with message-id <E1uTVvk-002cDv-30@fasolo.debian.org>
and subject line Bug#1107992: fixed in hurd 1:0.9.git20250622-1
has caused the Debian Bug report #1107992,
regarding drop Rules-Requires-Root
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1107992: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1107992
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: hurd
Version: 1:0.9.git20250420-1
Severity: wishlist
Tags: patch
X-Debbugs-Cc: debian@fabian.gruenbichler.email

Hi!

while looking through the archive for unrelated reasons, I noticed src:hurd is
the only package using Rules-Requires-Root: debhelper/upstream-make-install

the resulting wrapping of `make install` under fakeroot has no real effect, and
anything requiring root (like setting certain executables setuid) needs to be 
done once more afterwards by d/rules or debhelper anyway.

attached is a small patch that makes it possible to drop R³ and make the whole
build rootless, with bit-by-bit identical binary package output (including
udebs) according to my test build on the porterbox.

full debdiff dropping R³ attachted as well.

this has the advantage that new root-requiring steps in `make install` added
in future versions are not silently ignored (which would be the case currently),
but should actually fail the build.

I also noticed that the setuid binaries are not setuid in the udebs, which
might be worthy of a separate fix - but I don't know anything about hurd, so
I'll leave that to you :)

thanks for your consideration,
Fabian

-- System Information:
Debian Release: 13.0
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.12.30-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Attachment: debdiff
Description: Binary data

Description: fix rootless build
Instead of setting the owner and setuid bit during `make install` which
requires (fake) root, only set it in debian/rules via chown u+s

Author: Fabian Grünbichler <debian@fabian.gruenbichler.email>

---
Last-Update: 2025-06-18

--- hurd-0.9.git20250420.orig/daemons/Makefile
+++ hurd-0.9.git20250420/daemons/Makefile
@@ -31,8 +31,6 @@ HURDLIBS = fshelp ports shouldbeinlibc
 OBJS = $(SRCS:.c=.o)
 getty-LDLIBS = -lutil
 
-INSTALL-mail.local-ops = -o root -m 4755
-
 include ../Makeconf
 
 rc: rc.sh
--- hurd-0.9.git20250420.orig/utils/Makefile
+++ hurd-0.9.git20250420/utils/Makefile
@@ -42,11 +42,6 @@ setauth-LDLIBS = $(and $(HAVE_LIBCRYPT),
 mount-LDLIBS = $(libblkid_LIBS)
 mount-CPPFLAGS = $(libblkid_CFLAGS)
 
-INSTALL-login-ops = -o root -m 4755
-INSTALL-ids-ops = -o root -m 4755
-INSTALL-ps-ops = -o root -m 4755
-INSTALL-w-ops = -o root -m 4755
-
 include ../Makeconf
 
 ps addauth rmauth setauth unsu msgport: parse.o pids.o

--- End Message ---
--- Begin Message --- 
Source: hurd
Source-Version: 1:0.9.git20250622-1
Done: Samuel Thibault <sthibault@debian.org>

We believe that the bug you reported is fixed in the latest version of
hurd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1107992@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Thibault <sthibault@debian.org> (supplier of updated hurd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 22 Jun 2025 19:52:01 +0000
Source: hurd
Architecture: source
Version: 1:0.9.git20250622-1
Distribution: unstable
Urgency: medium
Maintainer: GNU Hurd Maintainers <debian-hurd@lists.debian.org>
Changed-By: Samuel Thibault <sthibault@debian.org>
Closes: 1107992
Changes:
 hurd (1:0.9.git20250622-1) unstable; urgency=medium
 .
   [ Fabian Grünbichler ]
   * patches/fix-rootless-build.patch: Fix rootless build.
   * control: Disable Root in debhelper/upstream-make-install
     (Closes: Bug#1107992)
 .
   [ Samuel Thibault ]
   * New upstream snapshot.
     - patches/git-ENOSPC: Upstreamed.
     - patches/git-console-client-compose: Upstreamed.
Checksums-Sha1:
 6939b640829b1d8ecfbc404a7c2ddda1054baa8a 3465 hurd_0.9.git20250622-1.dsc
 f96511fc6a3a6f3f439140cf0801ca7b9f3365b3 6678602 hurd_0.9.git20250622.orig.tar.gz
 1da7b88c755e76a5eb7c6b235708728dbeeb772b 78812 hurd_0.9.git20250622-1.debian.tar.xz
 b2db1d999916fa31abe9e13b4d5889f085a0a48f 8097 hurd_0.9.git20250622-1_source.buildinfo
Checksums-Sha256:
 358e67d98e7f3f99f26723809f43f4b80d9b0c7147304a21740b1f659d691d8d 3465 hurd_0.9.git20250622-1.dsc
 d08cd1d1b09d6d37fa3b1770c696dc0b7cb6f65551bc2fb406e7e3230da28788 6678602 hurd_0.9.git20250622.orig.tar.gz
 ad3f04c4425c1b8f9a1bff1c604a8365753890a5755f13cc8051b6894acd8790 78812 hurd_0.9.git20250622-1.debian.tar.xz
 fb5d168473d050c1357d2251bd629f8222a5f6477b5a00850eb61c261e3b0642 8097 hurd_0.9.git20250622-1_source.buildinfo
Files:
 635cffcdecce3790e6084354f9b03be8 3465 admin required hurd_0.9.git20250622-1.dsc
 86350f28b021c36cbf1ba7a322911b3a 6678602 admin required hurd_0.9.git20250622.orig.tar.gz
 0dc659c16f7f39272838a7f283c40944 78812 admin required hurd_0.9.git20250622-1.debian.tar.xz
 4354893736dfa513ee27efe393fa46ea 8097 admin required hurd_0.9.git20250622-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEZTSF1IMOAGwT71n/aHTOWK4tfj8FAmhYZ1EACgkQaHTOWK4t
fj+V8w/8CjmWr+CDRy7OCYsA7ymsprIAfXJf/BEULFgRSOO4Ku9Jz4jBxhi2wVc9
YrMd3l5BMhwoORKY9uQ51wJ6fvBYHkbo4Tb9EqSl5JKl5hXuQyLbqpXGw2xkiL4y
H+se21WT46wIFsPnWaQKr7Egq+MxjtzBjGknRdsWptVomUpXLEoGfJqdtxUJauM5
iC6q4Ouu87DCv3PwFzqmdcnHOhKWtwtZpy7b4yevSGyDMhd0AcULSbvLNZRT+BME
Ee7CCViXWBSOXdVmdou4xaiNQ8Fd+Cj0fN83fNe1LM7UXkHWRDeNfi9sKGKdEKbn
sO8T0SwERp+HSFLq3FfqeJqggD8Qfj6RG32Z2tUvNqla2Z8C3WUWB1UX6YgII9x6
q8ztKnC1Hk51zLdlegd3RjjsN4RdbTVLjCkH20Z6EPtcwCTA1KHHqPvDEwavtlql
LYCJTUYiasVeQp/tL+vVUVbJMXgrQ5mtHvz6+t5ByJ9EDHyIReiKnOpnJdw42Yh8
miCezjGlIrCNEnTHrv7da5VzcyqfyBns7MqSAnJ39PacHZ8j5dgf0QuPV7IGPYFf
U7RqtPuYvVO6RDekbbdZ4XkohRLCUkX7g8GSE6ffoUIYgDPWsmSM1NElbrwW8dQP
E2fe/aLHdysC8urVM8ITijv01SlkTGfqtmPcQObcT37XaC5ux4Y=
=KxUX
-----END PGP SIGNATURE-----

Attachment: pgpczS5j_I_1Y.pgp
Description: PGP signature


--- End Message ---
Reply to: