Re: Bug#1009712: sv: fails to control the service on Hurd

[Samuel Thibault <sthibault@debian.org>]

Control: reassign -1 hurd
Control: tags -1 + pending

Hello,

João Pedro Malhado, le sam. 28 déc. 2024 12:44:16 +0000, a ecrit:
> On Sun, Dec 23, 2024 at 05:38:14PM +0100, Samuel Thibault wrote:
> > There being no reader any more would have been caught by the original
> > code already:
> > 
> >        /* We're the last reader; when we're gone there is no more joy.  */
> >        detach = ((flags & O_READ) && pipe->readers == 1);
> > 
> > So probably that line could be restored as it was and just let the rest
> > as it is currently: in open_hook we properly make an incoming writer
> > either wait for a reader or immediately return ENXIO if here is none and
> > O_NDELAY was given.
> > 
> > Could you try to do the change and check that it fixes your issue?
> 
> Ok, I tried the modified fifo and now it works!
> I tried this on a somewhat ropey installation of 2023 release snapshot (procfs
> crashing all the time), but hopefully things have not changed since in this
> regard.
> 
> I also tried to copy new-fifo as fifo and things seemed to work as well.

Ok, I have pushed it.

> I guess this bug could be closed once a patched hurd is uploaded?

Yes, noted so.

Thanks for the investigation,
Samuel