[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#888640: gcab: FTBFS on hurd-i386: PATH_MAX undeclared

Source: gcab
Version: 1.0-1
Severity: normal
Tags: upstream
User: debian-hurd@lists.debian.org
Usertags: hurd

The latest build of gcab for hurd-i386 (admittedly not a release
architecture) failed:

  ../tests/gcab-self-test.c:33:19: error: ‘PATH_MAX’ undeclared (first use in this function); did you mean ‘NAME_MAX’?

The Hurd notoriously has no static PATH_MAX.  Best practice is
dynamically accommodating whatever you actually encounter, since
fixed-size buffers generally run the risk of either wasting memory or
yielding truncation (or, worse, buffer overflows).  However, if that's
infeasible, you can also look up _PC_PATH_MAX via pathconf or even
supply a fallback constant (traditionally 4096).

Could you please take a look?


Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?amu@monk.mit.edu

Reply to: