Re: Bug#757711: netcfg: promptly kills dhclient, deconfigures interface

[Steven Chamberlain <steven@pyro.eu.org>]

Hi,

Please may I commit this to d-i/netcfg (assuming my d-i Git privileges
include that repository).

As well as kfreebsd, I expect hurd is currently affected by this bug,
so this patch would also fix it there.

Thanks.

--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+netcfg (1.120) UNRELEASED; urgency=medium
+
+  [ Steven Chamberlain ]
+  * Do not kill_dhcp_client after setting the hostname and domain,
+    otherwise Linux udhcpc will stop renewing its lease, and on other
+    platforms dhclient will de-configure the network interface
+    (Closes: #757711, #757988)
+
+ -- Debian Install System Team <debian-boot@lists.debian.org>  Fri, 29 Aug 2014 22:05:47 +0100
+
 netcfg (1.119) unstable; urgency=medium
 
   [ Colin Watson ]
diff --git a/dhcp.c b/dhcp.c
index aa37bd0..5ef0dbc 100644
--- a/dhcp.c
+++ b/dhcp.c
@@ -614,7 +614,6 @@ int netcfg_activate_dhcp (struct debconfclient *client, struct netcfg_interface
                 netcfg_write_loopback();
                 netcfg_write_interface(interface);
                 netcfg_write_resolv(domain, interface);
-                kill_dhcp_client();
                 stop_rdnssd();
 
                 return 0;

-- 
Steven Chamberlain
steven@pyro.eu.org