Re: shadow: FTBFS on hurd-i386 (for review)
On Fri, 2014-05-23 at 13:27 +0200, Samuel Thibault wrote:
> Pino Toscano, le Fri 16 May 2014 13:20:14 +0200, a écrit :
> > On 2014-05-16 09:30, Svante Signell wrote:
> > >Currently shadow fails to build from source due to a usage of PATH_MAX,
> > >which is not defined on GNU/Hurd. The attached patch solved this problem
> > >by dynamically allocating space for the string proc_dir_name in files
> > >src/procuidmap.c and src/procgidmap.c and freeing it when not needed any
> > >longer.
> >
> > Considering proc_dir_name is always "/proc/%u/", dynamically allocating
> > memory for it is pointless, since it won't be longer than few characters
> > (which can be easily calculated in advance). Just put a shorter value
> > instead of PATH_MAX (like 64), with a comment explaining it.
>
> Yes, that'll be way a simpler patch.
It's in the TODO list already.
Reply to: