Re: libpgm: FTBFS on hurd-i386 (for review)

[Svante Signell <svante.signell@gmail.com>]

On Thu, 2014-05-01 at 22:35 +0200, Samuel Thibault wrote:
> Svante Signell, le Tue 22 Apr 2014 22:19:06 +0200, a écrit :
> > @@ -197,7 +197,7 @@
> >  AC_COMPILE_IFELSE(
> >  	[AC_LANG_PROGRAM([[#include <netinet/in.h>]],
> >  		[[struct group_req gr;
> > -gr.gr_interface = 0;]])],
> > +gr.gr_interface = 0; #ifndef MCAST_JOIN_GROUP; return -1; #else return 0; #endif]])],
> 
> Err, that will just always fail, #ifdef etc. have to be at the beginning
> of a line. Also, AC_COMPILE_IFELSE only catches compilation issues, not
> runtime issues.  What you want is:
> 
>  AC_COMPILE_IFELSE(
>  	[AC_LANG_PROGRAM([[#include <netinet/in.h>]],
>  		[[struct group_req gr;
> -gr.gr_interface = 0;]])],
> +gr.gr_interface = 0;
> +#ifndef MCAST_JOIN_GROUP
> +# error no mcast
> +#endif
> +]])],

So it was partly about adding newlines in the code, I suspected
something like that,

Thanks, a new patch will be submitted to the BTS.