Re: Bug#771052: fish: FTBFS on hurd-i386
- To: David Adam <zanchey@ucc.gu.uwa.edu.au>
- Cc: svante.signell@gmail.com, 771052@bugs.debian.org, Debian Bug Tracking System <submit@bugs.debian.org>, debian-bugs-dist@lists.debian.org, debian-hurd@lists.debian.org, Gustavo Noronha Silva <kov@debian.org>
- Subject: Re: Bug#771052: fish: FTBFS on hurd-i386
- From: Samuel Thibault <sthibault@debian.org>
- Date: Wed, 26 Nov 2014 15:40:37 +0100
- Message-id: <[🔎] 20141126144037.GD7102@type.bordeaux.inria.fr>
- Mail-followup-to: David Adam <zanchey@ucc.gu.uwa.edu.au>, svante.signell@gmail.com, 771052@bugs.debian.org, Debian Bug Tracking System <submit@bugs.debian.org>, debian-bugs-dist@lists.debian.org, debian-hurd@lists.debian.org, Gustavo Noronha Silva <kov@debian.org>
- In-reply-to: <[🔎] alpine.DEB.2.02.1411262156090.5097@motsugo.ucc.gu.uwa.edu.au>
- References: <[🔎] 1416999740.11764.330.camel@G3620.my.own.domain> <[🔎] alpine.DEB.2.02.1411262156090.5097@motsugo.ucc.gu.uwa.edu.au>
David Adam, le Wed 26 Nov 2014 22:01:00 +0800, a écrit :
> Above the lines you have changed is a comment:
>
> // In general, strerror is not async-safe, and therefore we cannot use it directly
> // So instead we have to grub through sys_nerr and sys_errlist directly
>
> Do you know if this has changed in recent glibc? If not, I would caution
> against changing this on all platforms.
It is always safe in the cases where one would be able to use
sys_errlist directly, actualy: in that case the glibc source code boils
down to return _sys_errlist_internal[errnum]).
Another way is to use strerror_r, which is standard since POSIX 2001.
Samuel
Reply to: