Re: glibc preparation patch for lockf support in Hurd
Svante Signell, le Tue 19 Aug 2014 06:55:43 +0200, a écrit :
> On Mon, 2014-08-18 at 23:39 +0200, Samuel Thibault wrote:
> > Svante Signell, le Mon 18 Aug 2014 21:56:19 +0200, a écrit :
> > > The reason this is needed is that the MIG generated RPC for hurd/glibc
> > > currently does not support mixed 32 and 64 bit entries,
> > Well, make it just always 64bit then. AIUI, this type is not used in
> > any RPC at all yet, so this can't break anything. See how this is done
> > for io_statbuf_t, it's always the 64bit content.
> Why not extend MIG to support mixed sizes (in addition to solving the
> non-uniqueness of the application)?
As cygwin people say it, PTC (Patch Thankfully Considered).
I'm not actually even sure how that would work. It would probably
mean teaching mig that some types may be int or long, then teaching
it to generate stubs for both cases with different names, and teach
it to generate a #define in the generated header, so as to select
the appropriate one depending on LFS being enabled or not. That can
probably be done. I don't know who will consider spending time on this,
though, thus PTC. It seems much more realistic to write the trivial
conversion functions in glibc.