Re: Bug#750424: cups-pk-helper: FTBFS on hurd-i386
On 2014-06-03 13:09, Svante Signell wrote:
On Tue, 2014-06-03 at 12:53 +0200, Pino Toscano wrote:
On 2014-06-03 12:19, Svante Signell wrote:
> Source: cups-pk-helper
> Version: 0.2.5-2
> Severity: important
> Tags: patch
> User: debian-hurd@lists.debian.org
> Usertags: hurd
>
> Hi,
>
> Currently the latest version of cups-pk-helper fails to build from
> source and is flagged as out-of-date. This is due to usage of
> PATH_MAX,
> which is not defined on GNU/Hurd. The attached patch solve this
> problem
> by defining PATH_MAX to 4096 in src/cups.c if not defined.
>
> The reason for not doing it differently is that the character
array
> newppdfile[] is used in function cupsTempFile2() to create a
> temporary
> file and this function is defined in the cups package, not in
> cups-pk-helper.
As I wrote in #750424: this has reported upstream already.
Svante: it would be *really* helpful if you could check upstream
before reporting upstream bugs to Debian. It isn't that difficult,
you don't need special skills to search into bug/issue trackers or
in VCSes. This will avoid duplicating work already done by someone
else.
Is it possible to file a Debian bug at the same time as the upstream
report, for simplicity?
For simplicity it would mean just report the bug upstream and wait
for fixed version to be uploaded.
Checking every upstream for fixed packages not in the Debian BTS
is tedious.
So what? This is what you need to do anyway, tedious or not, if you
take the job in porting something.
And it might be so that the Debian
Maintainer choose to approve the patch before upstream,
Or it can be the other way round, where maintainers do want
issues/patches filed/fixed upstream first before introducing
potentially incompatible changes in the packages.
It is also _much_ easier, in case you want to really have it fixed
in Debian without waiting for a new upstream release, to just ask
for the backport of a patch already committed upstream, as it is then
already reviewed and approved by upstream.
--
Pino Toscano
Reply to: